Add comment explaining each guard in ValidateSourceUrl

rounak610 · claude · rounak610 · commit c9bfb64c9087 · 2026-06-10T13:34:10.000+05:30
Co-Authored-By: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/BrowserStackLocal/BrowserStackLocal/BrowserStackTunnel.cs b/BrowserStackLocal/BrowserStackLocal/BrowserStackTunnel.cs
@@ -237,6 +237,11 @@ private string fetchSourceUrl(string accessKey)
       }
     }
 
+    // Each guard below covers a case the final host-equals check does not:
+    //   - null/empty URL: skip a parse attempt and give a clear error.
+    //   - Uri.TryCreate failure: malformed URL surfaces our own exception instead of leaving parsed null.
+    //   - HTTPS check: allowlist matches host only; without this, http://browserstack.com would pass.
+    //   - null/empty host: parsed.Host can be empty for some URL forms; give a clear error before reaching the allowlist loop.
     private static string ValidateSourceUrl(string url)
     {
       if (string.IsNullOrEmpty(url))

Original file line number	Diff line number	Diff line change
`@@ -237,6 +237,11 @@ private string fetchSourceUrl(string accessKey)`
`237`	`237`	`}`
`238`	`238`	`}`
`239`	`239`
	`240`	`+ // Each guard below covers a case the final host-equals check does not:`
	`241`	`+ // - null/empty URL: skip a parse attempt and give a clear error.`
	`242`	`+ // - Uri.TryCreate failure: malformed URL surfaces our own exception instead of leaving parsed null.`
	`243`	`+ // - HTTPS check: allowlist matches host only; without this, http://browserstack.com would pass.`
	`244`	`+ // - null/empty host: parsed.Host can be empty for some URL forms; give a clear error before reaching the allowlist loop.`
`240`	`245`	`private static string ValidateSourceUrl(string url)`
`241`	`246`	`{`
`242`	`247`	`if (string.IsNullOrEmpty(url))`