Merge branch 'main' of github.com:SavioBS629/mcp-server into fix/PMAA-147-tcg-batch-limits

SavioBS629 · SavioBS629 · commit ea3718aa22d7 · 2026-06-19T12:55:04.000+05:30
diff --git a/.github/workflows/mcp-ci.yml b/.github/workflows/mcp-ci.yml
@@ -4,6 +4,9 @@ on:
   pull_request_review:
     types: [submitted]
 
+permissions:
+  contents: read
+
 jobs:
   test:
     if: github.event.pull_request.base.ref == 'main' && github.event.review.state == 'approved'
diff --git a/.github/workflows/mcp-registry-publish.yml b/.github/workflows/mcp-registry-publish.yml
@@ -32,8 +32,7 @@ jobs:
 
       - name: Install MCP Publisher
         run: |
-          curl -L "https://github.com/modelcontextprotocol/registry/releases/download/v1.3.3/mcp-publisher_$(uname -s | tr '[:upper:]' '[:lower:]')_$(uname -m | sed 's/x86_64/amd64/;s/aarch64/arm64/').tar.gz" | tar xz mcp-publisher
-    
+          curl -L "https://github.com/modelcontextprotocol/registry/releases/download/v1.3.3/mcp-publisher_$(uname -s | tr '[:upper:]' '[:lower:]')_$(uname -m | sed 's/x86_64/amd64/;s/aarch64/arm64/').tar.gz" | tar xz mcp-publisher    
       - name: Login to MCP Registry
         run: ./mcp-publisher login github-oidc
 
diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml
@@ -5,6 +5,7 @@ on:
 
 permissions:
   contents: write
+  id-token: write
 
 jobs:
   publish:
@@ -99,7 +100,7 @@ jobs:
         run: git push origin ${{ steps.get_version.outputs.version }}
 
       - name: "Publish to NPM"
-        run: npm publish --access public
+        run: npm publish --access public --provenance
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
diff --git a/README.md b/README.md
@@ -85,6 +85,8 @@ Similar to the app testing, you can use the following prompts to test your **web
 Auto-analyze, diagnose, and even fix broken test scripts right in your IDE or LLM. Instantly fetch logs, identify root causes, and apply context-aware fixes. No more debugging loops.
 Below are few example prompts to run/debug/fix your automated tests on BrowserStack's [Test Platform](https://www.browserstack.com/test-platform).
 
+> **Note:** When fetching Root Cause Analysis (RCA) for a test, the server returns the suggested fix as a proposal only. It never applies code changes automatically — your assistant must present the suggestion and wait for your explicit approval before editing any files.
+
 ```bash
 #Port test suite to BrowserStack
 "Setup test suite to run on BrowserStack infra"
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@browserstack/mcp-server",
-  "version": "1.2.19",
+  "version": "1.2.22",
   "description": "BrowserStack's Official MCP Server",
   "mcpName": "io.github.browserstack/mcp-server",
   "main": "dist/index.js",
diff --git a/server.json b/server.json
@@ -11,7 +11,7 @@
     {
       "registryType": "npm",
       "identifier": "@browserstack/mcp-server",
-      "version": "1.2.19",
+      "version": "1.2.22",
       "transport": {
         "type": "stdio"
       },
diff --git a/src/lib/apiClient.ts b/src/lib/apiClient.ts
@@ -78,7 +78,6 @@ function getAxiosAgent(): AxiosRequestConfig["httpsAgent"] | undefined {
         host: proxyHost,
         port: Number(proxyPort),
         ca,
-        rejectUnauthorized: false, // Set to true if you want strict SSL
       });
     } else {
       // Proxy only
@@ -88,7 +87,6 @@ function getAxiosAgent(): AxiosRequestConfig["httpsAgent"] | undefined {
     // CA only
     return new https.Agent({
       ca: fs.readFileSync(caCertPath),
-      rejectUnauthorized: false, // Set to true for strict SSL
     });
   }
   // Default agent (no proxy, no CA)
diff --git a/src/tools/rca-agent-utils/format-rca.ts b/src/tools/rca-agent-utils/format-rca.ts
@@ -6,6 +6,10 @@ export function formatRCAData(rcaData: any): string {
 
   let output = "## Root Cause Analysis Report\n\n";
 
+  // Track whether any test case carries a fix suggestion so we can append the
+  // approval-gate directive only when it is relevant.
+  let hasFixSuggestion = false;
+
   rcaData.testCases.forEach((testCase: any, index: number) => {
     // Show test case ID with smaller heading
     output += `### Test Case ${index + 1}\n`;
@@ -29,7 +33,8 @@ export function formatRCAData(rcaData: any): string {
       }
 
       if (rca.possible_fix) {
-        output += `**Recommended Fix:**\n${rca.possible_fix}\n\n`;
+        hasFixSuggestion = true;
+        output += `**Suggested Fix (proposal only — do not apply without explicit user approval):**\n${rca.possible_fix}\n\n`;
       }
     } else if (testCase.rcaData?.error) {
       output += `**Error:** ${testCase.rcaData.error}\n\n`;
@@ -40,5 +45,12 @@ export function formatRCAData(rcaData: any): string {
     output += "---\n\n";
   });
 
+  if (hasFixSuggestion) {
+    output +=
+      "> **Action required:** The fixes above are suggestions only. " +
+      "Present them to the user and apply code changes ONLY after the user " +
+      "explicitly approves. Do not modify any files automatically.\n";
+  }
+
   return output;
 }
diff --git a/src/tools/rca-agent.ts b/src/tools/rca-agent.ts
@@ -144,11 +144,16 @@ export default function addRCATools(
 
   tools.fetchRCA = server.tool(
     "fetchRCA",
-    "Retrieves AI-RCA (Root Cause Analysis) data for a BrowserStack Automate and App-Automate session and provides insights into test failures.",
+    "Fetch AI Root Cause Analysis for failed BrowserStack Automate/App-Automate tests. Suggests fixes only; never auto-apply, require explicit user approval.",
     FETCH_RCA_PARAMS,
     async (args) => {
       try {
-        trackMCP("fetchRCA", server.server.getClientVersion()!, config);
+        trackMCP(
+          "fetchRCA",
+          server.server.getClientVersion()!,
+          undefined,
+          config,
+        );
         return await fetchRCADataTool(args, config);
       } catch (error) {
         return handleMCPError("fetchRCA", server, config, error);
@@ -162,7 +167,12 @@ export default function addRCATools(
     GET_BUILD_ID_PARAMS,
     async (args) => {
       try {
-        trackMCP("getBuildId", server.server.getClientVersion()!, config);
+        trackMCP(
+          "getBuildId",
+          server.server.getClientVersion()!,
+          undefined,
+          config,
+        );
         return await getBuildIdTool(args, config);
       } catch (error) {
         return handleMCPError("getBuildId", server, config, error);
@@ -176,7 +186,12 @@ export default function addRCATools(
     LIST_TEST_IDS_PARAMS,
     async (args) => {
       try {
-        trackMCP("listTestIds", server.server.getClientVersion()!, config);
+        trackMCP(
+          "listTestIds",
+          server.server.getClientVersion()!,
+          undefined,
+          config,
+        );
         return await listTestIdsTool(args, config);
       } catch (error) {
         return handleMCPError("listTestIds", server, config, error);
diff --git a/src/tools/testmanagement-utils/create-testcase.ts b/src/tools/testmanagement-utils/create-testcase.ts
@@ -21,6 +21,14 @@ interface IssueTracker {
   host: string;
 }
 
+// A custom field value may be a scalar or, for multi-select fields, an array
+// of option values. The TM API accepts arrays only when keyed by field NAME.
+export type CustomFieldValue =
+  | string
+  | number
+  | boolean
+  | Array<string | number>;
+
 export interface TestCaseCreateRequest {
   project_identifier: string;
   folder_id: string;
@@ -32,9 +40,10 @@ export interface TestCaseCreateRequest {
   issues?: string[];
   issue_tracker?: IssueTracker;
   tags?: string[];
-  custom_fields?: Record<string, string>;
+  custom_fields?: Record<string, CustomFieldValue>;
   automation_status?: string;
   priority?: string;
+  template?: string;
 }
 
 export interface TestCaseResponse {
@@ -66,6 +75,14 @@ export interface TestCaseResponse {
   };
 }
 
+// Scalar value, or an array of values for multi-select custom fields.
+export const customFieldValueSchema = z.union([
+  z.string(),
+  z.number(),
+  z.boolean(),
+  z.array(z.union([z.string(), z.number()])),
+]);
+
 export const CreateTestCaseSchema = z.object({
   project_identifier: z
     .string()
@@ -122,9 +139,11 @@ export const CreateTestCaseSchema = z.object({
       "Tags to attach to the test case. This should be strictly in array format not the string of json",
     ),
   custom_fields: z
-    .record(z.string(), z.string())
+    .record(z.string(), customFieldValueSchema)
     .optional()
-    .describe("Map of custom field names to values."),
+    .describe(
+      "Map of custom field NAME to value; use an array for multi-select fields.",
+    ),
   automation_status: z
     .string()
     .optional()
@@ -137,6 +156,12 @@ export const CreateTestCaseSchema = z.object({
     .describe(
       "Priority of the test case. Accepts either display name (e.g. 'Critical', 'High', 'Medium', 'Low') or internal name (e.g. 'medium'). If omitted, the project default (usually 'Medium') is applied. Valid values are per-project and discoverable via the form-fields endpoint.",
     ),
+  template: z
+    .string()
+    .optional()
+    .describe(
+      "Template internal slug, e.g. 'test_case_steps' or 'test_case_bdd'. Use the slug, not the display name.",
+    ),
 });
 
 export function sanitizeArgs(args: any) {
@@ -146,6 +171,7 @@ export function sanitizeArgs(args: any) {
   if (cleaned.owner === null) delete cleaned.owner;
   if (cleaned.preconditions === null) delete cleaned.preconditions;
   if (cleaned.automation_status === null) delete cleaned.automation_status;
+  if (cleaned.template === null) delete cleaned.template;
 
   if (cleaned.issue_tracker) {
     if (
@@ -245,22 +271,33 @@ export async function createTestCase(
       config,
     );
 
-    return {
-      content: [
-        {
-          type: "text",
-          text: `Test case successfully created:
+    const content: Array<{ type: "text"; text: string }> = [];
+
+    // The TM API silently ignores an unrecognized template slug and falls back
+    // to the default. Surface that instead of letting it pass as success.
+    if (
+      params.template &&
+      tc.template &&
+      String(tc.template).toLowerCase() !==
+        String(params.template).toLowerCase()
+    ) {
+      content.push({
+        type: "text",
+        text: `Warning: requested template "${params.template}" was not applied — the test case was created with "${tc.template}". BrowserStack expects the template's internal slug (e.g. "test_case_steps", "test_case_bdd") and silently uses the default for unrecognized values.`,
+      });
+    }
+
+    content.push({
+      type: "text",
+      text: `Test case successfully created:
             - Identifier: ${tc.identifier}
             - Title: ${tc.title}
 
           You can view it here: ${tmBaseUrl}/projects/${projectId}/folder/search?q=${tc.identifier}`,
-        },
-        {
-          type: "text",
-          text: JSON.stringify(tc, null, 2),
-        },
-      ],
-    };
+    });
+    content.push({ type: "text", text: JSON.stringify(tc, null, 2) });
+
+    return { content };
   } catch (err) {
     // Delegate to our centralized Axios error formatter
     return formatAxiosError(err, "Failed to create test case");
diff --git a/src/tools/testmanagement-utils/update-testcase.ts b/src/tools/testmanagement-utils/update-testcase.ts
@@ -29,7 +29,10 @@ export interface TestCaseUpdateRequest {
   status?: string;
   tags?: string[];
   issues?: string[];
-  custom_fields?: Record<string, string | number | boolean>;
+  custom_fields?: Record<
+    string,
+    string | number | boolean | Array<string | number>
+  >;
 }
 
 export const UpdateTestCaseSchema = z.object({
@@ -101,10 +104,18 @@ export const UpdateTestCaseSchema = z.object({
       "Replacement list of linked Jira/Asana/Azure issue IDs for the test case.",
     ),
   custom_fields: z
-    .record(z.string(), z.union([z.string(), z.number(), z.boolean()]))
+    .record(
+      z.string(),
+      z.union([
+        z.string(),
+        z.number(),
+        z.boolean(),
+        z.array(z.union([z.string(), z.number()])),
+      ]),
+    )
     .optional()
     .describe(
-      "Map of custom field name/id to value. Valid field names and value types are per-project; discover them via the project's form fields.",
+      "Map of custom field NAME to value; use an array for multi-select fields.",
     ),
 });
 
diff --git a/tests/tools/formatRCAData.test.ts b/tests/tools/formatRCAData.test.ts
@@ -0,0 +1,58 @@
+import { describe, it, expect } from "vitest";
+import { formatRCAData } from "../../src/tools/rca-agent-utils/format-rca";
+
+describe("formatRCAData", () => {
+  it("returns a no-data message when there are no test cases", () => {
+    expect(formatRCAData(null)).toBe("No RCA data available.");
+    expect(formatRCAData({ testCases: [] })).toBe("No RCA data available.");
+  });
+
+  it("labels a suggested fix as a proposal and appends the approval-gate directive", () => {
+    const output = formatRCAData({
+      testCases: [
+        {
+          id: 101,
+          state: "failed",
+          rcaData: {
+            rcaData: {
+              root_cause: "Selector changed",
+              possible_fix: "Update the locator to the new data-testid",
+            },
+          },
+        },
+      ],
+    });
+
+    // The fix is framed as a proposal, not an instruction to apply.
+    expect(output).toContain("Suggested Fix (proposal only");
+    expect(output).toContain("do not apply without explicit user approval");
+
+    // The approval-gate directive must be present so consuming agents do not
+    // auto-apply code changes.
+    expect(output).toContain("Action required");
+    expect(output).toContain(
+      "apply code changes ONLY after the user explicitly approves",
+    );
+    expect(output).toContain("Do not modify any files automatically");
+  });
+
+  it("omits the approval-gate directive when no fix is suggested", () => {
+    const output = formatRCAData({
+      testCases: [
+        {
+          id: 102,
+          state: "failed",
+          rcaData: {
+            rcaData: {
+              root_cause: "Network timeout",
+            },
+          },
+        },
+      ],
+    });
+
+    expect(output).toContain("Network timeout");
+    expect(output).not.toContain("Action required");
+    expect(output).not.toContain("Suggested Fix");
+  });
+});
diff --git a/tests/tools/testmanagement.test.ts b/tests/tools/testmanagement.test.ts

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@browserstack/mcp-server",`
`3`		`- "version": "1.2.19",`
	`3`	`+ "version": "1.2.22",`
`4`	`4`	`"description": "BrowserStack's Official MCP Server",`
`5`	`5`	`"mcpName": "io.github.browserstack/mcp-server",`
`6`	`6`	`"main": "dist/index.js",`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`{`
`12`	`12`	`"registryType": "npm",`
`13`	`13`	`"identifier": "@browserstack/mcp-server",`
`14`		`- "version": "1.2.19",`
	`14`	`+ "version": "1.2.22",`
`15`	`15`	`"transport": {`
`16`	`16`	`"type": "stdio"`
`17`	`17`	`},`