refactor(testmanagement): share default-field normalization; trim case_type prompt

- Extract normalizeDefaultFields into TCG-utils/api.ts, shared by createTestCase
  and updateTestCase (removes the duplicated per-file helper; update keeps its
  automation_status quirk in the shared impl).
- Trim the case_type .describe() to ~80 chars, under the tool-design 120 ceiling.
- Add a test asserting normalized case_type reaches the v1 create body when
  template_id is set.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: SavioBS629

src/tools/testmanagement-utils/TCG-utils/api.ts

@@ -58,6 +58,60 @@ export function normalizeDefaultFieldValue(
   return match.internal_name ?? match.name;
 }
 
+export interface DefaultFieldInputs {
+  priority?: string;
+  case_type?: string;
+  automation_status?: string;
+}
+
+/**
+ * Normalize priority/case_type/automation_status against a project's already
+ * fetched `default_fields`. priority and case_type resolve to the display name
+ * (the create/update endpoints reject lowercase internal names); on no match
+ * the raw value passes through. automation_status is special: its values carry
+ * a null internal_name and hold the internal name in `value`, so it matches on
+ * name-or-value and emits `value`. Callers own the fetch and its error path.
+ */
+export function normalizeDefaultFields(
+  defaultFields: any,
+  inputs: DefaultFieldInputs,
+): DefaultFieldInputs {
+  const out: DefaultFieldInputs = {};
+
+  if (inputs.priority !== undefined) {
+    out.priority =
+      normalizeDefaultFieldValue(
+        defaultFields?.priority?.values ?? [],
+        inputs.priority,
+        "name",
+      ) ?? inputs.priority;
+  }
+  if (inputs.case_type !== undefined) {
+    out.case_type =
+      normalizeDefaultFieldValue(
+        defaultFields?.case_type?.values ?? [],
+        inputs.case_type,
+        "name",
+      ) ?? inputs.case_type;
+  }
+  if (inputs.automation_status !== undefined) {
+    const values =
+      (defaultFields?.automation_status?.values as Array<{
+        name?: string;
+        value?: string;
+      }>) ?? [];
+    const input = inputs.automation_status.toLowerCase().trim();
+    const match = values.find(
+      (v) =>
+        (v.value ?? "").toLowerCase() === input ||
+        (v.name ?? "").toLowerCase() === input,
+    );
+    out.automation_status = match?.value ?? inputs.automation_status;
+  }
+
+  return out;
+}
+
 /**
  * Trigger AI-based test case generation for a document.
  */

src/tools/testmanagement-utils/create-testcase.ts

@@ -4,7 +4,7 @@ import { CallToolResult } from "@modelcontextprotocol/sdk/types.js";
 import { formatAxiosError } from "../../lib/error.js";
 import {
   fetchFormFields,
-  normalizeDefaultFieldValue,
+  normalizeDefaultFields as normalizeDefaultFieldsFromForm,
   projectIdentifierToId,
 } from "./TCG-utils/api.js";
 import { BrowserStackConfig } from "../../lib/types.js";
@@ -163,7 +163,7 @@ export const CreateTestCaseSchema = z.object({
     .string()
     .optional()
     .describe(
-      "Test case type. Accepts either display name (e.g. 'Functional', 'Regression', 'Smoke & Sanity') or internal name (e.g. 'functional', 'smoke_sanity'). If omitted, the project default (usually 'Other') is applied. Valid values are per-project.",
+      "Test case type display or internal name (per-project). Omit for project default.",
     ),
   template: z
     .string()
@@ -204,9 +204,9 @@ export function sanitizeArgs(args: any) {
 import { getBrowserStackAuth } from "../../lib/get-auth.js";
 
 /**
- * Normalize priority and case_type to the display names the create endpoint
- * accepts (it rejects lowercase internal names). Fetches the project's
- * form-fields once; on lookup failure, passes raw values through.
+ * Fetch the project's form-fields and normalize priority/case_type to the
+ * display names the create endpoint accepts (it rejects lowercase internal
+ * names). On lookup failure, passes raw values through.
  */
 async function normalizeDefaultFields(
   projectIdentifier: string,
@@ -219,24 +219,7 @@ async function normalizeDefaultFields(
       config,
     );
     const { default_fields } = await fetchFormFields(numericProjectId, config);
-    const out: { priority?: string; case_type?: string } = {};
-    if (fields.priority !== undefined) {
-      out.priority =
-        normalizeDefaultFieldValue(
-          default_fields?.priority?.values ?? [],
-          fields.priority,
-          "name",
-        ) ?? fields.priority;
-    }
-    if (fields.case_type !== undefined) {
-      out.case_type =
-        normalizeDefaultFieldValue(
-          default_fields?.case_type?.values ?? [],
-          fields.case_type,
-          "name",
-        ) ?? fields.case_type;
-    }
-    return out;
+    return normalizeDefaultFieldsFromForm(default_fields, fields);
   } catch (err) {
     logger.warn(
       "Failed to normalize default fields; passing through as given: %s",

src/tools/testmanagement-utils/update-testcase.ts

@@ -4,7 +4,7 @@ import { CallToolResult } from "@modelcontextprotocol/sdk/types.js";
 import { formatAxiosError } from "../../lib/error.js";
 import {
   fetchFormFields,
-  normalizeDefaultFieldValue,
+  normalizeDefaultFields as normalizeDefaultFieldsFromForm,
   projectIdentifierToId,
 } from "./TCG-utils/api.js";
 import { BrowserStackConfig } from "../../lib/types.js";
@@ -146,47 +146,11 @@ async function normalizeDefaultFields(
     );
     const { default_fields } = await fetchFormFields(numericProjectId, config);
 
-    const out: {
-      priority?: string;
-      case_type?: string;
-      automation_status?: string;
-    } = {};
-
-    if (params.priority !== undefined) {
-      out.priority =
-        normalizeDefaultFieldValue(
-          default_fields?.priority?.values ?? [],
-          params.priority,
-          "name",
-        ) ?? params.priority;
-    }
-    if (params.case_type !== undefined) {
-      out.case_type =
-        normalizeDefaultFieldValue(
-          default_fields?.case_type?.values ?? [],
-          params.case_type,
-          "name",
-        ) ?? params.case_type;
-    }
-    if (params.automation_status !== undefined) {
-      // automation_status.values have null internal_name and the internal
-      // name is actually held in `value` (see API inspection). Accept
-      // either the display name or the internal snake_case form.
-      const values =
-        (default_fields?.automation_status?.values as Array<{
-          name?: string;
-          value?: string;
-        }>) ?? [];
-      const input = params.automation_status.toLowerCase().trim();
-      const match = values.find(
-        (v) =>
-          (v.value ?? "").toLowerCase() === input ||
-          (v.name ?? "").toLowerCase() === input,
-      );
-      out.automation_status = match?.value ?? params.automation_status;
-    }
-
-    return out;
+    return normalizeDefaultFieldsFromForm(default_fields, {
+      priority: params.priority,
+      case_type: params.case_type,
+      automation_status: params.automation_status,
+    });
   } catch (err) {
     logger.warn(
       "Failed to normalize default field values; passing through as given: %s",

tests/tools/testmanagement.test.ts

@@ -97,11 +97,17 @@ vi.mock('../../src/lib/inmemory-store', () => ({ signedUrlMap: new Map() }));
 vi.mock('../../src/lib/get-auth', () => ({
   getBrowserStackAuth: vi.fn(() => 'fake-user:fake-key')
 }));
-vi.mock('../../src/tools/testmanagement-utils/TCG-utils/api', () => ({
-  projectIdentifierToId: vi.fn(() => Promise.resolve('999')),
-  fetchFormFields: vi.fn(),
-  normalizeDefaultFieldValue: vi.fn(),
-}));
+vi.mock('../../src/tools/testmanagement-utils/TCG-utils/api', async (importActual) => {
+  const actual = await importActual<
+    typeof import('../../src/tools/testmanagement-utils/TCG-utils/api')
+  >();
+  return {
+    ...actual,
+    projectIdentifierToId: vi.fn(() => Promise.resolve('999')),
+    fetchFormFields: vi.fn(),
+    normalizeDefaultFieldValue: vi.fn(),
+  };
+});
 vi.mock('form-data', () => {
   return {
     default: vi.fn().mockImplementation(() => ({
@@ -1077,7 +1083,6 @@ describe('createTestCase — priority normalization', () => {
   let createTestCaseReal: typeof import('../../src/tools/testmanagement-utils/create-testcase').createTestCase;
   let apiClientMock: typeof import('../../src/lib/apiClient').apiClient;
   let fetchFormFieldsMock: Mock;
-  let normalizeMock: Mock;
 
   beforeAll(async () => {
     const actual = await vi.importActual<
@@ -1087,7 +1092,6 @@ describe('createTestCase — priority normalization', () => {
     apiClientMock = (await import('../../src/lib/apiClient')).apiClient;
     const api = await import('../../src/tools/testmanagement-utils/TCG-utils/api');
     fetchFormFieldsMock = api.fetchFormFields as unknown as Mock;
-    normalizeMock = api.normalizeDefaultFieldValue as unknown as Mock;
   });
 
   beforeEach(() => {
@@ -1126,7 +1130,6 @@ describe('createTestCase — priority normalization', () => {
 
   it('looks up the project form fields and sends the normalized priority in the request body', async () => {
     fetchFormFieldsMock.mockResolvedValue(formFields);
-    normalizeMock.mockReturnValue('Critical');
     (apiClientMock.post as Mock).mockResolvedValueOnce(createSuccess);
 
     const result = await createTestCaseReal(
@@ -1135,7 +1138,8 @@ describe('createTestCase — priority normalization', () => {
     );
 
     expect(result.isError).toBeFalsy();
-    expect(normalizeMock).toHaveBeenCalledWith(priorityValues, 'critical', 'name');
+    // Real normalizeDefaultFields maps the internal name 'critical' to the
+    // display name 'Critical' the create endpoint requires.
     const body = (apiClientMock.post as Mock).mock.calls[0][0].body;
     expect(body.test_case.priority).toBe('Critical');
   });
@@ -1173,7 +1177,6 @@ describe('createTestCase — priority normalization', () => {
       default_fields: { case_type: { values: caseTypeValues } },
       custom_fields: {},
     });
-    normalizeMock.mockReturnValue('Functional');
     (apiClientMock.post as Mock).mockResolvedValueOnce(createSuccess);
 
     const result = await createTestCaseReal(
@@ -1182,7 +1185,7 @@ describe('createTestCase — priority normalization', () => {
     );
 
     expect(result.isError).toBeFalsy();
-    expect(normalizeMock).toHaveBeenCalledWith(caseTypeValues, 'functional', 'name');
+    // Real normalizeDefaultFields maps 'functional' to the display name 'Functional'.
     const body = (apiClientMock.post as Mock).mock.calls[0][0].body;
     expect(body.test_case.case_type).toBe('Functional');
   });
@@ -1217,9 +1220,6 @@ describe('createTestCase — priority normalization', () => {
       },
       custom_fields: {},
     });
-    normalizeMock.mockImplementation((_values, input) =>
-      input === 'critical' ? 'Critical' : 'Functional',
-    );
     (apiClientMock.post as Mock).mockResolvedValueOnce(createSuccess);
 
     await createTestCaseReal(
@@ -1410,6 +1410,30 @@ describe('createTestCase — template & multi-select custom_fields', () => {
     expect(call.body.test_case.folder_id).toBeUndefined();
   });
 
+  // case_type must survive into the v1 test_case body (spread from
+  // testCaseParams), normalized to the display name the endpoint accepts.
+  it('carries the normalized case_type into the v1 body when template_id is set', async () => {
+    const api = await import('../../src/tools/testmanagement-utils/TCG-utils/api');
+    (api.fetchFormFields as Mock).mockResolvedValue({
+      default_fields: {
+        case_type: {
+          values: [{ name: 'Functional', internal_name: 'functional', value: 1 }],
+        },
+      },
+      custom_fields: [],
+    });
+    (apiClientMock.post as Mock).mockResolvedValueOnce(respWithId(656127));
+
+    await createTestCaseReal(
+      { ...baseArgs, template_id: 656127, case_type: 'functional' },
+      mockConfig as any,
+    );
+
+    const call = (apiClientMock.post as Mock).mock.calls[0][0];
+    expect(call.url).toContain('/api/v1/projects/');
+    expect(call.body.test_case.case_type).toBe('Functional');
+  });
+
   it('translates custom_fields name→id and option value→id on the v1 path', async () => {
     const api = await import('../../src/tools/testmanagement-utils/TCG-utils/api');
     (api.fetchFormFields as Mock).mockResolvedValueOnce({