fix: attach auth header on RCA tool MCPInstrumentation events#315
Open
aadarsh-bs wants to merge 1 commit into
Open
fix: attach auth header on RCA tool MCPInstrumentation events#315aadarsh-bs wants to merge 1 commit into
aadarsh-bs wants to merge 1 commit into
Conversation
fetchRCA, getBuildId and listTestIds called trackMCP with config in the 3rd (error) argument slot, leaving the config param undefined. Without config, no Authorization header is attached and the /sdk/v1/event endpoint silently drops the event (raise_error:false + .catch), so these tools logged zero usage despite being invoked. Pass undefined as the error arg and config as the 4th, matching the other tools. Fixes AIMCP-187. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AIMCP-187. fetchRCA/getBuildId/listTestIds pass config into trackMCP's error slot (3-arg call), so no auth header is attached and /sdk/v1/event silently drops the event — these tools log zero usage despite being invoked. Fix passes undefined as the error arg and config as the 4th. Build+tests pass; verified end-to-end (0 events before, success=true after). Full RCA on the ticket.