-
Notifications
You must be signed in to change notification settings - Fork 51
fix: wrap rich-text fields in <p> so TM renders special characters correctly #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Dave3130
merged 4 commits into
browserstack:main
from
SavioBS629:fix/pmaa-185-richtext-gt-encoding
Jul 30, 2026
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
82a3be2
fix(testmanagement): wrap rich-text fields in <p> so TM renders speci…
SavioBS629 cc3a498
refactor(testmanagement): trim rich-text comments, add generality tests
SavioBS629 aca16d4
fix(testmanagement): escape rich text before p-wrapping, mirror TM's …
SavioBS629 e3a1332
fix: removed comment
SavioBS629 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // TM UI renders these fields as rich text only when HTML-wrapped; | ||
| const LOOKS_LIKE_HTML = /^\s*<[a-z][^>]*>/i; | ||
|
SavioBS629 marked this conversation as resolved.
Outdated
|
||
| const HAS_ENCODABLE_CHARS = /[<>&]/; | ||
|
|
||
| export function wrapRichText(text: string): string { | ||
| if (LOOKS_LIKE_HTML.test(text) || !HAS_ENCODABLE_CHARS.test(text)) { | ||
| return text; | ||
| } | ||
| return `<p>${text}</p>`; | ||
|
SavioBS629 marked this conversation as resolved.
Outdated
|
||
| } | ||
|
|
||
| export function wrapTestCaseSteps<T extends { step: string; result: string }>( | ||
| steps: T[], | ||
| ): T[] { | ||
| return steps.map((s) => ({ | ||
| ...s, | ||
| step: wrapRichText(s.step), | ||
| result: wrapRichText(s.result), | ||
| })); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| import { describe, it, expect } from 'vitest'; | ||
| import { | ||
| wrapRichText, | ||
| wrapTestCaseSteps, | ||
| } from '../../src/tools/testmanagement-utils/rich-text'; | ||
|
|
||
| describe('wrapRichText', () => { | ||
| it('wraps bare text containing > in <p> tags', () => { | ||
| expect(wrapRichText('Navigate to Settings > Users')).toBe( | ||
| '<p>Navigate to Settings > Users</p>', | ||
| ); | ||
| }); | ||
|
|
||
| it('wraps bare text containing < in <p> tags', () => { | ||
| expect(wrapRichText('if a < b then pass')).toBe( | ||
| '<p>if a < b then pass</p>', | ||
| ); | ||
| }); | ||
|
|
||
| it('wraps bare text containing & in <p> tags', () => { | ||
| expect(wrapRichText('Q&A section loads')).toBe('<p>Q&A section loads</p>'); | ||
| }); | ||
|
|
||
| it('leaves text without <, > or & untouched', () => { | ||
| expect(wrapRichText('Click "Save" then \'Confirm\'')).toBe( | ||
| 'Click "Save" then \'Confirm\'', | ||
| ); | ||
| }); | ||
|
|
||
| it('leaves already-HTML content untouched', () => { | ||
| expect(wrapRichText('<p>Settings > Users</p>')).toBe( | ||
| '<p>Settings > Users</p>', | ||
| ); | ||
| expect(wrapRichText(' <ul><li>A & B</li></ul>')).toBe( | ||
| ' <ul><li>A & B</li></ul>', | ||
| ); | ||
| }); | ||
|
|
||
| it('wraps text starting with < that is not a tag', () => { | ||
| expect(wrapRichText('< 5 items are shown')).toBe( | ||
| '<p>< 5 items are shown</p>', | ||
| ); | ||
| }); | ||
|
|
||
| it('handles any characters, not just fixed strings', () => { | ||
| expect(wrapRichText('émojis 🎉 and ünïcode ≥ 5 stay bare')).toBe( | ||
| 'émojis 🎉 and ünïcode ≥ 5 stay bare', | ||
| ); | ||
| expect(wrapRichText('unicode plus html char: 温度 > 30°C')).toBe( | ||
| '<p>unicode plus html char: 温度 > 30°C</p>', | ||
| ); | ||
| expect(wrapRichText('line1 a > b\nline2 c < d')).toBe( | ||
| '<p>line1 a > b\nline2 c < d</p>', | ||
| ); | ||
| expect(wrapRichText('a>=b && c<=d & "e"')).toBe( | ||
| '<p>a>=b && c<=d & "e"</p>', | ||
| ); | ||
| }); | ||
| }); | ||
|
|
||
| describe('wrapTestCaseSteps', () => { | ||
| it('wraps step and result independently and preserves other keys', () => { | ||
| expect( | ||
| wrapTestCaseSteps([ | ||
| { step: 'Go to A > B', result: 'B page loads' }, | ||
| { step: 'Click Save', result: 'Count > 0' }, | ||
| ]), | ||
| ).toEqual([ | ||
| { step: '<p>Go to A > B</p>', result: 'B page loads' }, | ||
| { step: 'Click Save', result: '<p>Count > 0</p>' }, | ||
| ]); | ||
| }); | ||
|
|
||
| it('returns an empty array unchanged', () => { | ||
| expect(wrapTestCaseSteps([])).toEqual([]); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.