Skip to content

Commit ce21957

Browse files
Address review: trim meta/cross-repo comments
- BStackLocalSampleTest.cs: drop xunit-reqnroll pointer; keep a one-line `browserstackLocal` + port-45454 prerequisite note. - AssemblyInfo.cs: collapse parallelism explainer to a single line about the SDK-spawned-process invariant. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 97bef30 commit ce21957

2 files changed

Lines changed: 3 additions & 12 deletions

File tree

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
// Allow NUnit to run [TestFixture] classes in parallel within each SDK-spawned
2-
// platform process. Combined with `parallelsPerPlatform: 2` in browserstack.yml,
3-
// each `dotnet test` produces 4 platforms x 2 fixtures = 8 concurrent sessions.
1+
// Run [TestFixture] classes in parallel within each SDK-spawned platform process.
42
[assembly: NUnit.Framework.Parallelizable(NUnit.Framework.ParallelScope.Fixtures)]
53
[assembly: NUnit.Framework.LevelOfParallelism(4)]

NunitPlaywrightBrowserstack.Tests/BStackLocalSampleTest.cs

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,7 @@
11
namespace NunitPlaywrightBrowserstack.Tests;
22

3-
// Mirrors xunit-reqnroll-playwright-browserstack's Features/LocalSample.feature
4-
// + StepDefinitions/LocalSampleSteps.cs:
5-
// page.GotoAsync("http://bs-local.com:45454/") + title.Contains("BrowserStack Local")
6-
//
7-
// Requires:
8-
// * browserstack.yml has `browserstackLocal: true`
9-
// * a local HTTP server is serving a page with title containing "BrowserStack Local"
10-
// on port 45454 (the sanity workflow stands up `python -m http.server 45454`
11-
// against a one-file index.html harness).
3+
// Requires browserstack.yml has `browserstackLocal: true` and a local HTTP server
4+
// is serving a page with title containing "BrowserStack Local" on port 45454.
125
[TestFixture]
136
[Parallelizable(ParallelScope.Self)]
147
public class BStackLocalSampleTest : PlaywrightFixtureBase

0 commit comments

Comments
 (0)