Skip to content

treat raw import marker as a "poisoned state"#1111

Open
SmaGMan wants to merge 20 commits into
masterfrom
feature/poisoned-raw-import-marker
Open

treat raw import marker as a "poisoned state"#1111
SmaGMan wants to merge 20 commits into
masterfrom
feature/poisoned-raw-import-marker

Conversation

@SmaGMan

@SmaGMan SmaGMan commented Jul 1, 2026

Copy link
Copy Markdown
Member

Merge after #1100


Set RawImportInProgress marker on zerostate or persistent state import start and remove when import fully finished. If import fail the marker will persist. Node start will fail if RawImportInProgress marker exist and will require re-sync.

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

[None]

BLOCKCHAIN CONFIGURATION MODEL CHANGES

[None]


COMPATIBILITY

Fully compatible

SPECIAL DEPLOYMENT ACTIONS

[Not Required]


PERFORMANCE IMPACT

[No impact expected]


TESTS

Unit Tests

Covered by:

  • storage_open_rejects_existing_raw_import_marker
  • finished_raw_import_marker_allows_storage_open

Network Tests

[No coverage]

Manual Tests

Manual tests used:

  • start network
  • deploy 1kk accounts
  • force persistent state using HACK
  • stop one node and drop its
  • start node, wait when persistent import starts, then stop node
  • try to start node - it should fail

@SmaGMan SmaGMan requested review from 0xdeafbeef, Mododo and Rexagon July 1, 2026 10:11
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1111

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1111
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1111 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@SmaGMan SmaGMan linked an issue Jul 1, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.75248% with 561 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.20%. Comparing base (7235431) to head (dd34bf1).

Files with missing lines Patch % Lines
core/src/block_strider/starter/cold_boot.rs 0.00% 211 Missing ⚠️
core/src/storage/persistent_state/tests.rs 79.26% 18 Missing and 89 partials ⚠️
core/src/storage/shard_state/store_state_raw.rs 82.11% 19 Missing and 30 partials ⚠️
core/src/storage/persistent_state/mod.rs 67.12% 30 Missing and 18 partials ⚠️
core/src/storage/shard_state/mod.rs 78.39% 20 Missing and 15 partials ⚠️
...src/storage/persistent_state/shard_state/writer.rs 90.24% 11 Missing and 13 partials ⚠️
core/src/storage/shard_state/cell_storage/raw.rs 94.37% 7 Missing and 11 partials ⚠️
core/src/blockchain_rpc/client.rs 71.92% 15 Missing and 1 partial ⚠️
core/src/block_strider/starter/starter_client.rs 0.00% 13 Missing ⚠️
...src/storage/persistent_state/shard_state/reader.rs 72.41% 3 Missing and 5 partials ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1111      +/-   ##
==========================================
+ Coverage   59.86%   60.20%   +0.34%     
==========================================
  Files         484      486       +2     
  Lines       82721    84720    +1999     
  Branches    82721    84720    +1999     
==========================================
+ Hits        49522    51009    +1487     
- Misses      30850    31192     +342     
- Partials     2349     2519     +170     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mododo

Mododo commented Jul 9, 2026

Copy link
Copy Markdown
Member

lgtm

@SmaGMan SmaGMan force-pushed the feature/poisoned-raw-import-marker branch from 8fc62a2 to ee10db6 Compare July 10, 2026 15:25
@SmaGMan SmaGMan force-pushed the feature/poisoned-raw-import-marker branch from ee10db6 to 8e4026b Compare July 10, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use RawImportInProgress as a "poisoned" marker and require re-sync

3 participants