Midi Thru#16
Open
earjuice wants to merge 3 commits into
Open
Conversation
Owner
|
@felixfaire could you like to have a look, please? |
Contributor
|
My only concern with this is that it posts 2 async functions to the ioservice for every callback instead 1. Which seems like overkill for what seems like quite a rare edge case. If you think this is a valuable feature to others I might suggest adding another bool switch to enable raw midi instead of the midi message objects. Ideally this would also work similar to (and alongside) |
Owner
|
yes, a boolean like mMidiThru would be the way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did this to forward the raw midi unsigned char to the midiOut low level sendMessage function. It works, but I'm not sure how stable it is... Perhaps there is a better way?