Skip to content

Commit edf0cc7

Browse files
committed
clone certificates
test only managedhttps
1 parent 01f96e5 commit edf0cc7

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

src/Docker.DotNet/Microsoft.Net.Http.Client/ManagedHandler.cs

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,17 @@ private async Task<HttpResponseMessage> ProcessRequestAsync(HttpRequestMessage r
172172

173173
if (request.IsHttps())
174174
{
175+
X509CertificateCollection clonedCertificates = new X509CertificateCollection();
176+
if (ClientCertificates != null)
177+
{
178+
foreach (var cert in ClientCertificates)
179+
{
180+
clonedCertificates.Add(cert);
181+
}
182+
}
183+
175184
SslStream sslStream = new SslStream(transport, false, ServerCertificateValidationCallback);
176-
await sslStream.AuthenticateAsClientAsync(request.GetHostProperty(), ClientCertificates, SslProtocols.Tls12, false);
185+
await sslStream.AuthenticateAsClientAsync(request.GetHostProperty(), clonedCertificates, SslProtocols.Tls12, false);
177186
transport = sslStream;
178187
}
179188

test/Docker.DotNet.Tests/TestFixture.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,8 @@ public static IEnumerable<object[]> GetDockerClientTypes()
221221
.Select(t => new object[] { t });
222222
}
223223

224-
return allClients.Select(t => new object[] { t });
224+
//return allClients.Select(t => new object[] { t });
225+
return allClients.Where(t => t == TestClientsEnum.ManagedHttps).Select(t => new object[] { t });
225226
}
226227

227228
public static IEnumerable<TestDaemonsEnum> GetDockerDaemonTypes()

0 commit comments

Comments
 (0)