add-variant-selection-dropdown#753
Merged
Merged
Conversation
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
webview-ui/src/components/asset/AssetGeneral.vue:1446-1448
Variant names with spaces will break the CLI command. `Object.keys(variants)` values are user-defined YAML/JSON keys that can contain spaces; appending them unquoted causes the shell to split the argument (e.g. `--variant my variant` becomes two separate tokens). The same risk applies to the existing `--environment` flag, but it is compounded here since variant keys are less constrained than environment names. Wrap the value in quotes to prevent the split.
```suggestion
if (hasVariants.value && selectedVariant.value && selectedVariant.value.trim() !== "") {
payload += ` --variant "${selectedVariant.value}"`;
}
```
### Issue 2 of 2
webview-ui/src/components/ui/select-menu/VariantSelectMenu.vue:23
In Vue 3 `<script setup>`, `defineProps` and `defineEmits` are compiler macros injected globally — they do not need to be imported. The import is a no-op in practice but is unnecessary noise. The sibling `EnvSelectMenu.vue` has the same pattern; both can drop it.
Reviews (1): Last reviewed commit: "add-variant-selection-dropdown" | Re-trigger Greptile |
mustafa3rsan
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.