Skip to content

add-variant-selection-dropdown#753

Merged
TanayBensuYurtturk merged 3 commits into
mainfrom
patch/add-variant-selection-dropdown
May 11, 2026
Merged

add-variant-selection-dropdown#753
TanayBensuYurtturk merged 3 commits into
mainfrom
patch/add-variant-selection-dropdown

Conversation

@TanayBensuYurtturk
Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 11, 2026

Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
webview-ui/src/components/asset/AssetGeneral.vue:1446-1448
Variant names with spaces will break the CLI command. `Object.keys(variants)` values are user-defined YAML/JSON keys that can contain spaces; appending them unquoted causes the shell to split the argument (e.g. `--variant my variant` becomes two separate tokens). The same risk applies to the existing `--environment` flag, but it is compounded here since variant keys are less constrained than environment names. Wrap the value in quotes to prevent the split.

```suggestion
  if (hasVariants.value && selectedVariant.value && selectedVariant.value.trim() !== "") {
    payload += ` --variant "${selectedVariant.value}"`;
  }
```

### Issue 2 of 2
webview-ui/src/components/ui/select-menu/VariantSelectMenu.vue:23
In Vue 3 `<script setup>`, `defineProps` and `defineEmits` are compiler macros injected globally — they do not need to be imported. The import is a no-op in practice but is unnecessary noise. The sibling `EnvSelectMenu.vue` has the same pattern; both can drop it.

Reviews (1): Last reviewed commit: "add-variant-selection-dropdown" | Re-trigger Greptile

Comment thread webview-ui/src/components/asset/AssetGeneral.vue
Comment thread webview-ui/src/components/ui/select-menu/VariantSelectMenu.vue
@TanayBensuYurtturk TanayBensuYurtturk merged commit d1deddb into main May 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants