fix: more tweaks for the access of the values

Author: brunomikoski

CHANGELOG.MD

@@ -11,7 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Changed the Refresh of the collections to only find items under the same folder.
 - Fixed a lot of scripts to work properly with multiple collections of the same type
 - Added some logs when `CollectionItems` are added/removed from collections to help the visibility
-
+- `CollectionType.Values` now will return all the `CollectionItem` available on the registry, so if you have 2 Collections of the one Type this will return the content of both collections while the `CollectionItem.Values` when the access file is generated will only return that specific collection items
 
 ## [1.5.4]
 ### Changed

Scripts/Runtime/Core/ScriptableObjectCollection.cs

@@ -52,7 +52,7 @@ private void SyncGUID()
 
             guid = Guid.NewGuid().ToString();
 #if UNITY_EDITOR
-            guid = UnityEditor.AssetDatabase.AssetPathToGUID(UnityEditor.AssetDatabase.GetAssetPath(this));
+            guid = AssetDatabase.AssetPathToGUID(UnityEditor.AssetDatabase.GetAssetPath(this));
             ObjectUtility.SetDirty(this);
 #endif
         }
@@ -124,6 +124,7 @@ public bool Add(ScriptableObjectCollectionItem item)
 
             item.SetCollection(this);
             ObjectUtility.SetDirty(this);
+            ClearCachedValues();
             return true;
         }
 
@@ -135,7 +136,7 @@ public ScriptableObjectCollectionItem AddNew(Type collectionType, string assetNa
                 throw new NotSupportedException();
 
             ScriptableObjectCollectionItem item = (ScriptableObjectCollectionItem)CreateInstance(collectionType);
-            string assetPath = Path.GetDirectoryName(UnityEditor.AssetDatabase.GetAssetPath(this));
+            string assetPath = Path.GetDirectoryName(AssetDatabase.GetAssetPath(this));
             string parentFolderPath = Path.Combine(assetPath, "Items");
             AssetDatabaseUtils.CreatePathIfDontExist(parentFolderPath);
 
@@ -164,7 +165,7 @@ public ScriptableObjectCollectionItem AddNew(Type collectionType, string assetNa
             string newFileName = Path.Combine(parentFolderPath, item.name + ".asset");
 
             this.Add(item);
-            UnityEditor.AssetDatabase.CreateAsset(item, newFileName);
+            AssetDatabase.CreateAsset(item, newFileName);
             ObjectUtility.SetDirty(this);
             return item;
         }
@@ -373,25 +374,31 @@ internal void PrepareForEditorMode()
             ObjectUtility.SetDirty(this);
         }
 
+        protected virtual void ClearCachedValues()
+        {
+        }
     }
 
     public class ScriptableObjectCollection<ObjectType> : ScriptableObjectCollection, IList<ObjectType>
         where ObjectType : ScriptableObjectCollectionItem
     {
-        private static ScriptableObjectCollection<ObjectType> values;
-        public static ScriptableObjectCollection<ObjectType> Values => values;
+        protected static List<ObjectType> cachedValues;
+        public static List<ObjectType> Values
+        {
+            get
+            {
+                if (cachedValues == null)
+                    cachedValues = CollectionsRegistry.Instance.GetAllCollectionItemsOfType<ObjectType>();
+                return cachedValues;
+            }
+        }
 
         public new ObjectType this[int index]
         {
             get => (ObjectType)base[index];
             set => base[index] = value;
         }
 
-        private void OnEnable()
-        {
-            values = this;
-        }
-
         public new IEnumerator<ObjectType> GetEnumerator()
         {
             using (IEnumerator<ScriptableObjectCollectionItem> itemEnum = base.GetEnumerator())
@@ -472,11 +479,13 @@ public ObjectType GetItemByGUID(string targetGUID)
         public void Add(ObjectType item)
         {
             base.Add(item);
+            ClearCachedValues();
         }
 
         public ObjectType Add(Type itemType = null)
         {
             ObjectType item = base.Add(itemType) as ObjectType;
+            ClearCachedValues();
             return item;
         }
 
@@ -498,11 +507,13 @@ public int IndexOf(ObjectType item)
         public void Insert(int index, ObjectType item)
         {
             base.Insert(index, item);
+            ClearCachedValues();
         }
 
         public bool Remove(ObjectType item)
         {
             bool remove = base.Remove(item);
+            ClearCachedValues();
             return remove;
         }
 
@@ -521,5 +532,11 @@ IEnumerator IEnumerable.GetEnumerator()
         {
             return base.GetEnumerator();
         }
+        
+        protected override void ClearCachedValues()
+        {
+            cachedValues = null;
+        }
+
     }
 }