Merge pull request #57 from Thundernerd/fix/GetOrAddNew_nullref

brunomikoski · web-flow · commit 111f79dcbb60 · 2021-02-13T18:38:00.000Z
Changed .First() to .FirstOrDefault()
diff --git a/Scripts/Runtime/ScriptableObjectCollection.cs b/Scripts/Runtime/ScriptableObjectCollection.cs
@@ -442,7 +442,7 @@ public ObjectType GetOrAddNew(Type collectionType, string targetName)
         
         public ObjectType GetOrAddNew(string targetName)
         {
-            ObjectType item = Items.First(o => o.name.Equals(targetName, StringComparison.Ordinal)) as ObjectType;
+            ObjectType item = Items.FirstOrDefault(o => o.name.Equals(targetName, StringComparison.Ordinal)) as ObjectType;
             if (item != null)
                 return item;
 

Original file line number	Diff line number	Diff line change
`@@ -442,7 +442,7 @@ public ObjectType GetOrAddNew(Type collectionType, string targetName)`
`442`	`442`
`443`	`443`	`public ObjectType GetOrAddNew(string targetName)`
`444`	`444`	`{`
`445`		`- ObjectType item = Items.First(o => o.name.Equals(targetName, StringComparison.Ordinal)) as ObjectType;`
	`445`	`+ ObjectType item = Items.FirstOrDefault(o => o.name.Equals(targetName, StringComparison.Ordinal)) as ObjectType;`
`446`	`446`	`if (item != null)`
`447`	`447`	`return item;`
`448`	`448`