fix: last known name usability

Author: brunomikoski

Scripts/Editor/PropertyDrawers/CollectionItemIndirectReferencePropertyDrawer.cs

@@ -50,7 +50,8 @@ public override void OnGUI(Rect position, SerializedProperty property, GUIConten
             collectionLastKnownNameSerializedProperty = property.FindPropertyRelative(COLLECTION_LAST_KNOW_NAME_PROPERTY_PATH);
 
             TryGetCollectionItem(out ScriptableObject collectionItem);
-            
+            ValidateLastKnownNames(collectionItem);
+
             int indexOfArrayPart = property.propertyPath.IndexOf('[');
             if (indexOfArrayPart > -1)
             {
@@ -132,6 +133,31 @@ private bool TryGetCollectionItem(out ScriptableObject item)
             return true;
         }
 
+        private void ValidateLastKnownNames(ScriptableObject collectionItem)
+        {
+            if (collectionItem == null || collectionItem is not ISOCItem socItem)
+                return;
+
+            bool changed = false;
+
+            if (!string.Equals(itemLastKnowNameSerializedProperty.stringValue, socItem.name, StringComparison.Ordinal))
+            {
+                itemLastKnowNameSerializedProperty.stringValue = socItem.name;
+                changed = true;
+            }
+
+            if (!string.Equals(collectionLastKnownNameSerializedProperty.stringValue, socItem.Collection.name, StringComparison.Ordinal))
+            {
+                collectionLastKnownNameSerializedProperty.stringValue = socItem.Collection.name;
+                changed = true;
+            }
+
+            if (changed)
+            {
+                itemLastKnowNameSerializedProperty.serializedObject.ApplyModifiedPropertiesWithoutUndo();
+            }
+        }
+
         private void CreateCollectionItemPropertyDrawer(SerializedProperty serializedProperty)
         {
             collectionItemPropertyDrawer = new CollectionItemPropertyDrawer();

Scripts/Editor/PropertyDrawers/CollectionItemPickerPropertyDrawer.cs

@@ -204,6 +204,9 @@ private void AssignItemGUIDToProperty(ScriptableObject scriptableObject, Seriali
 
             newProperty.FindPropertyRelative(COLLECTION_GUID_VALUE_A).longValue = collectionValues.Item1;
             newProperty.FindPropertyRelative(COLLECTION_GUID_VALUE_B).longValue = collectionValues.Item2;
+
+            newProperty.FindPropertyRelative("itemLastKnownName").stringValue = item.name;
+            newProperty.FindPropertyRelative("collectionLastKnownName").stringValue = item.Collection.name;
         }
 
         private void SetSelectedValuesOnPopup(PopupList<PopupItem> popupList, SerializedProperty property)

Scripts/Runtime/Core/CollectionItemIndirectReference.cs

@@ -20,10 +20,12 @@ public abstract class CollectionItemIndirectReference: IEquatable<CollectionItem
         protected long collectionGUIDValueB;
         protected LongGuid CollectionGUID => new LongGuid(collectionGUIDValueA, collectionGUIDValueB);
 
+#if UNITY_EDITOR
         [SerializeField]
         protected string itemLastKnownName;
         [SerializeField, FormerlySerializedAs("collectionLastKnowName")]
         protected string collectionLastKnownName;
+#endif
 
         public bool Equals(CollectionItemIndirectReference other)
         {
@@ -111,30 +113,6 @@ private bool TryResolveReference(out TObject result)
                     return true;
                 }
             }
-            else
-            {
-                if (!string.IsNullOrEmpty(collectionLastKnownName))
-                {
-                    if (CollectionsRegistry.Instance.TryGetCollectionByName(collectionLastKnownName, out collection))
-                    {
-                        SetCollection(collection);
-
-                        if (!string.IsNullOrEmpty(itemLastKnownName))
-                        {
-                            if(collection.TryGetItemByName(itemLastKnownName, out ScriptableObject possibleResult))
-                            {
-                                result = possibleResult as TObject;
-                                if (result == null)
-                                {
-                                    return false;
-                                }
-                                SetCollectionItem(result);
-                                return true;
-                            }
-                        }
-                    }
-                }
-            }
 
             result = null;
             return false;
@@ -160,15 +138,19 @@ private void SetCollectionItem(ISOCItem item)
             (long, long) collectionItemValues = item.GUID.GetRawValues();
             collectionItemGUIDValueA = collectionItemValues.Item1;
             collectionItemGUIDValueB = collectionItemValues.Item2;
+#if UNITY_EDITOR
             itemLastKnownName = item.name;
+#endif
         }
 
         public void SetCollection(ScriptableObjectCollection targetCollection)
         {
             (long,long) collectionGUIDValues = targetCollection.GUID.GetRawValues();
             collectionGUIDValueA = collectionGUIDValues.Item1;
             collectionGUIDValueB = collectionGUIDValues.Item2;
+#if UNITY_EDITOR
             collectionLastKnownName = targetCollection.name;
+#endif
         }
     }
 }