Merge pull request #117 from brunomikoski/feature/updates-for-200

Feature/updates for 200

Author: brunomikoski

CHANGELOG.MD

@@ -6,11 +6,35 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [2.0.0]
+### Changed
+- Fixed issue with name parser that would still treat digits as string and added to the final name
+- Fixed issue with PropertyDrawer of indirect reference without attribute would cause a null reference
+- Refactored the system to use ScriptableObject as a base class instead of `ScriptableObjectCollectionItem` now any `ScriptableObject` can be used as a collection item as long as implements the `ISCOItem` interface
+- Fixed issue with `CollectionItemPicker` that would not work properly with `ScriptableObject` that are not in the same assembly as the `ScriptableObjectCollection`
+- Added new buttons on CollectionRegistry to force guid validation on all items
+- Reduced automatic collection guid reloading to reduce performance impact on larger projects
+- Fixed issues with target scripts generation folder not being saved properly
+- Minimum supported Unity version is now 2021 _(I'm DONE with 2020, its the worst unity ever 😒)_
+
+### Removed
+ - Removed support for Addressables, it was not working properly and it was not being used by a lot of teams, I think the addressables support should be handled elsewhere.
+
+### Breaking Changes
+- If you used the Addressables integration `SOC_ADDRESSABLES_SUPPORT` be extra careful when upgrading
+- The old string based guid system has been replaced for a lighter version `LongGuid`
+- If you are using IndirectReferences all the references will be lost, you will need to re-set them
+
+### Upgrade Guide from 1.x.x to 2.x.x
+- Update the package
+- Make sure you click on the `CollectionRegistry` and click on the `Validate Collections` button
+- Regenerate all your Static Code Files
+
+
 # [1.9.7]
 ### Added
 - Initial string search support
 
-
 ### Changed
 - Fixed issue with namespace not been updated on first usage
 
@@ -384,6 +408,7 @@ public bool IsValidConsumable(Consumable consumable)
 ### Added 
  - First initial working version 
 
+[2.0.0]: https://github.com/badawe/ScriptableObjectCollection/releases/tag/v2.0.0
 [1.9.7]: https://github.com/badawe/ScriptableObjectCollection/releases/tag/v1.9.7
 [1.9.6]: https://github.com/badawe/ScriptableObjectCollection/releases/tag/v1.9.6
 [1.9.5]: https://github.com/badawe/ScriptableObjectCollection/releases/tag/v1.9.5

Scripts/Editor/BrunoMikoski.ScriptableObjectCollection.Editor.asmdef

@@ -2,8 +2,7 @@
     "name": "BrunoMikoski.ScriptableObjectCollection.Editor",
     "rootNamespace": "",
     "references": [
-        "BrunoMikoski.ScriptableObjectCollection",
-        "Unity.Addressables.Editor"
+        "BrunoMikoski.ScriptableObjectCollection"
     ],
     "includePlatforms": [
         "Editor"
@@ -14,12 +13,6 @@
     "precompiledReferences": [],
     "autoReferenced": true,
     "defineConstraints": [],
-    "versionDefines": [
-        {
-            "name": "com.unity.addressables",
-            "expression": "1.0.0",
-            "define": "SOC_ADDRESSABLES"
-        }
-    ],
+    "versionDefines": [],
     "noEngineReferences": false
 }

Scripts/Editor/Core/CollectionAssetsModificationProcessor.cs

@@ -1,5 +1,7 @@
 using System;
 using UnityEditor;
+using UnityEngine;
+using Object = System.Object;
 
 namespace BrunoMikoski.ScriptableObjectCollections
 {
@@ -13,12 +15,16 @@ public static AssetDeleteResult OnWillDeleteAsset(string targetAssetPath, Remove
 
             Type type = mainAssetAtPath.GetType();
 
-            if (type.IsSubclassOf(typeof(ScriptableObjectCollectionItem)))
+            if (type.IsSubclassOf(typeof(ScriptableObject)))
             {
-                ScriptableObjectCollectionItem collectionItem =
-                    AssetDatabase.LoadAssetAtPath<ScriptableObjectCollectionItem>(targetAssetPath);
+                ScriptableObject collectionItem =
+                    AssetDatabase.LoadAssetAtPath<ScriptableObject>(targetAssetPath);
 
-                collectionItem.Collection.Remove(collectionItem);
+                ISOCItem socItem = collectionItem as ISOCItem;
+                if (socItem == null)
+                    return AssetDeleteResult.DidNotDelete;
+
+                socItem.Collection.Remove(collectionItem);
                 return AssetDeleteResult.DidNotDelete;
             }