Skip to content

Commit 8495848

Browse files
authored
Merge pull request #101 from brunomikoski/fix/unity-2021-compability
fix: issue with runtimeinitialize method
2 parents 2a4d0a9 + f74ba36 commit 8495848

4 files changed

Lines changed: 8 additions & 7 deletions

File tree

CHANGELOG.MD

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
66

77
## [Unreleased]
88

9+
# [1.8.3]
10+
### Changed
11+
- Fixed `[RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.BeforeSceneLoad)]` issue with unity 2021 and generics.
912

1013
# [1.8.2]
1114
### Changed
@@ -333,6 +336,7 @@ public bool IsValidConsumable(Consumable consumable)
333336
- First initial working version
334337

335338

339+
[1.8.3]: https://github.com/badawe/ScriptableObjectCollection/releases/tag/v1.8.3
336340
[1.8.2]: https://github.com/badawe/ScriptableObjectCollection/releases/tag/v1.8.2
337341
[1.8.1]: https://github.com/badawe/ScriptableObjectCollection/releases/tag/v1.8.1
338342
[1.8.0]: https://github.com/badawe/ScriptableObjectCollection/releases/tag/v1.8.0

Scripts/Runtime/Core/CollectionsRegistry.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,12 @@ public class CollectionsRegistry : ResourceScriptableObjectSingleton<Collections
1616
[SerializeField]
1717
private List<ScriptableObjectCollection> collections = new List<ScriptableObjectCollection>();
1818

19-
[Preserve]
20-
public void UsedOnlyForAOTCodeGeneration()
19+
[RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.BeforeSceneLoad)]
20+
private static void Initialize()
2121
{
2222
LoadOrCreateInstance<CollectionsRegistry>();
23-
// Include an exception so we can be sure to know if this method is ever called.
24-
throw new InvalidOperationException("This method is used for AOT code generation only. Do not call it at runtime.");
2523
}
26-
24+
2725
public bool IsKnowCollection(ScriptableObjectCollection targetCollection)
2826
{
2927
for (int i = 0; i < collections.Count; i++)

Scripts/Runtime/Core/ResourceScriptableObjectSingleton.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ public static T Instance
1717
}
1818
}
1919

20-
[RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.BeforeSceneLoad)]
2120
public static TInstance LoadOrCreateInstance<TInstance>() where TInstance : ScriptableObject
2221
{
2322
if (!TryToLoadInstance<TInstance>(out TInstance resultInstance))

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "com.brunomikoski.scriptableobjectcollection",
33
"displayName": "Scriptable Object Collection",
4-
"version": "1.8.2",
4+
"version": "1.8.3",
55
"unity": "2018.4",
66
"description": "A library to help improve the usability of Unity3D Scriptable Objects by grouping then into a collection and exposing then by code or nice inspectors!",
77
"keywords": [

0 commit comments

Comments
 (0)