add: guid lockup for collections

Author: brunomikoski

Scripts/Runtime/Core/CollectionsRegistry.cs

@@ -20,7 +20,9 @@ public class CollectionsRegistry : ResourceScriptableObjectSingleton<Collections
         [SerializeField]
         private List<ScriptableObjectCollection> collections = new List<ScriptableObjectCollection>();
         public IReadOnlyList<ScriptableObjectCollection> Collections => collections;
-        
+
+        private Dictionary<LongGuid, ScriptableObjectCollection> collectionGuidLookup = new();
+
         [SerializeField, HideInInspector]
         private bool autoSearchForCollections;
         public bool AutoSearchForCollections => autoSearchForCollections;
@@ -47,9 +49,10 @@ public void RegisterCollection(ScriptableObjectCollection targetCollection)
         {
             if (collections.Contains(targetCollection))
                 return;
-            
+
             collections.Add(targetCollection);
-            
+            RebuildGuidLookup();
+
             ObjectUtility.SetDirty(this);
         }
 
@@ -60,7 +63,8 @@ public void UnregisterCollection(ScriptableObjectCollection targetCollection)
 
             if (!collections.Remove(targetCollection))
                 return;
-            
+
+            RebuildGuidLookup();
             ObjectUtility.SetDirty(this);
         }
 
@@ -243,14 +247,34 @@ public ScriptableObjectCollection GetCollectionByGUID(string guid)
 
         public ScriptableObjectCollection GetCollectionByGUID(LongGuid guid)
         {
+            if (collectionGuidLookup.Count == 0 && collections.Count > 0)
+                RebuildGuidLookup();
+
+            if (collectionGuidLookup.TryGetValue(guid, out ScriptableObjectCollection cached) && cached != null)
+                return cached;
+
             for (int i = 0; i < collections.Count; i++)
             {
                 if (collections[i] != null && collections[i].GUID == guid)
+                {
+                    collectionGuidLookup[guid] = collections[i];
                     return collections[i];
+                }
             }
 
             return null;
         }
+
+        private void RebuildGuidLookup()
+        {
+            collectionGuidLookup.Clear();
+            for (int i = 0; i < collections.Count; i++)
+            {
+                ScriptableObjectCollection collection = collections[i];
+                if (collection != null && collection.GUID.IsValid())
+                    collectionGuidLookup[collection.GUID] = collection;
+            }
+        }
 
         public bool TryGetCollectionOfType(Type type, out ScriptableObjectCollection resultCollection)
         {
@@ -377,6 +401,7 @@ public void ReloadCollections()
             {
                 ValidateCollections();
                 collections = foundCollections;
+                RebuildGuidLookup();
                 ObjectUtility.SetDirty(this);
             }
 #endif