add: cache

Author: brunomikoski

Scripts/Runtime/Core/ScriptableObjectCollection.cs

@@ -46,6 +46,7 @@ public LongGuid GUID
         public virtual bool ShouldProtectItemOrder => false;
 
         private Dictionary<string,ScriptableObject> itemNameToScriptableObject = new();
+        private Dictionary<LongGuid,ScriptableObject> itemGuidToScriptableObject = new();
 
         public ScriptableObject this[int index]
         {
@@ -468,10 +469,13 @@ public void RefreshCollection()
         public void CacheItemNames()
         {
             itemNameToScriptableObject.Clear();
+            itemGuidToScriptableObject.Clear();
             for (int i = 0; i < items.Count; i++)
             {
                 ScriptableObject item = items[i];
                 itemNameToScriptableObject.TryAdd(item.name, item);
+                if (item is ISOCItem socItem && socItem.GUID.IsValid())
+                    itemGuidToScriptableObject.TryAdd(socItem.GUID, item);
             }
         }
 
@@ -499,16 +503,23 @@ public bool TryGetItemByGUID<T>(LongGuid itemGUID, out T scriptableObjectCollect
         {
             if (itemGUID.IsValid())
             {
+                if (itemGuidToScriptableObject.TryGetValue(itemGUID, out ScriptableObject cached))
+                {
+                    scriptableObjectCollectionItem = cached as T;
+                    return scriptableObjectCollectionItem != null;
+                }
+
                 for (int i = 0; i < items.Count; i++)
                 {
                     ScriptableObject item = items[i];
                     ISOCItem socItem = item as ISOCItem;
                     if (socItem == null)
                         continue;
-                
+
                     if (socItem.GUID == itemGUID)
                     {
                         scriptableObjectCollectionItem = item as T;
+                        itemGuidToScriptableObject[itemGUID] = item;
                         return scriptableObjectCollectionItem != null;
                     }
                 }
@@ -524,6 +535,8 @@ public bool TryGetItemByGUID(LongGuid itemGUID, out ScriptableObject scriptableO
 
         protected virtual void ClearCachedValues()
         {
+            itemGuidToScriptableObject.Clear();
+            itemNameToScriptableObject.Clear();
         }
     }
 
@@ -546,8 +559,6 @@ public static IReadOnlyList<TObjectType> Values
             get => (TObjectType)base[index];
             set => base[index] = value;
         }
-        
-        private readonly Dictionary<Type, List<TObjectType>> typeToItems = new();
 
 
         public new IEnumerator<TObjectType> GetEnumerator()