Merge pull request #189 from brunomikoski/feature/reduce-gc-allocation

brunomikoski · web-flow · commit e307c28c8e25 · 2026-04-03T09:21:26.000-03:00
Reduce GC allocations in Matches function
diff --git a/Scripts/Runtime/Core/CollectionItemQuery.cs b/Scripts/Runtime/Core/CollectionItemQuery.cs
@@ -37,6 +37,8 @@ public override string ToString()
         [SerializeField]
         private QuerySet[] query = Array.Empty<QuerySet>();
 
+        private HashSet<LongGuid> targetGuids = new HashSet<LongGuid>(128);
+
         public bool Matches(params T[] targetItems)
         {
             return Matches(targetItems, out _);
@@ -63,7 +65,7 @@ public override string ToString()
 
         public bool Matches(IEnumerable<T> targetItems, out int resultMatchCount)
         {
-            HashSet<LongGuid> targetGuids = new HashSet<LongGuid>();
+            targetGuids.Clear();
             foreach (T item in targetItems)
             {
                 if (item) 

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,8 @@ public override string ToString()`
`37`	`37`	`[SerializeField]`
`38`	`38`	`private QuerySet[] query = Array.Empty<QuerySet>();`
`39`	`39`
	`40`	`+ private HashSet<LongGuid> targetGuids = new HashSet<LongGuid>(128);`
	`41`	`+`
`40`	`42`	`public bool Matches(params T[] targetItems)`
`41`	`43`	`{`
`42`	`44`	`return Matches(targetItems, out _);`
`@@ -63,7 +65,7 @@ public override string ToString()`
`63`	`65`
`64`	`66`	`public bool Matches(IEnumerable<T> targetItems, out int resultMatchCount)`
`65`	`67`	`{`
`66`		`- HashSet<LongGuid> targetGuids = new HashSet<LongGuid>();`
	`68`	`+ targetGuids.Clear();`
`67`	`69`	`foreach (T item in targetItems)`
`68`	`70`	`{`
`69`	`71`	`if (item)`