Fix node failure test cases

Author: brunorijsman

client/client.py

@@ -3,6 +3,7 @@
 """
 
 import asyncio
+import sys
 from typing import Any, List, Tuple
 from uuid import UUID
 from fastapi import status
@@ -241,14 +242,23 @@ def summarize_failure(hub_results: List[Any]) -> Tuple[List[str], int]:
         - A list of cause strings (included in the details of the ETSI exception)
         - The status code to be used in the ETSI exception, the worst of the peer status codes.
         """
+        print("Summarizing failures from hub results:", file=sys.stderr)  ### DEBUG
         status_code = None
         causes = []
         for hub_result in hub_results:
             if isinstance(hub_result, Exception):
                 causes.append(str(hub_result))
             if isinstance(hub_result, exceptions.DSKEException):
                 if status_code is None or hub_result.status_code > status_code:
+                    print(
+                        f"New worst status code: {hub_result.status_code} from hub result: {hub_result}",
+                        file=sys.stderr,
+                    )  ### DEBUG
                     status_code = hub_result.status_code
         if status_code is None:
-            status_code = status.HTTP_500_INTERNAL_SERVER_ERROR
+            print
+            status_code = status.HTTP_503_SERVICE_UNAVAILABLE
+        print(
+            f"Final summarized status code: {status_code}", file=sys.stderr
+        )  ### DEBUG
         return (causes, status_code)

common/exceptions.py

@@ -62,6 +62,8 @@ def __init__(
         response: str | None = None,
         exception: str | None = None,
     ):
+        if status_code is None:
+            status_code = status.HTTP_503_SERVICE_UNAVAILABLE
         details = {}
         details["method"] = method
         details["url"] = url
@@ -71,8 +73,7 @@ def __init__(
             details["params"] = params
         if data is not None:
             details["data"] = data
-        if status_code is not None:
-            details["status_code"] = status_code
+        details["status_code"] = status_code
         if response is not None:
             details["response"] = response
         if exception is not None:
@@ -86,11 +87,7 @@ def __init__(
             except Exception:  # pylint: disable=broad-except
                 pass
         message = f"HTTP request failed ({method} {url}: {status_code}{explain})."
-        super().__init__(
-            status_code=status_code or status.HTTP_500_INTERNAL_SERVER_ERROR,
-            message=message,
-            details=details,
-        )
+        super().__init__(status_code=status_code, message=message, details=details)
 
 
 class InvalidKeyIDError(DSKEException):