Add -ExcludeExternal to Find-MarkdownImages (#52)

* wip
* minor refactorings to support platform agnostic paths

Author: bryanbcook

src/public/Find-MarkdownImages.ps1

@@ -14,6 +14,9 @@
 .PARAMETER AttachmentsDirectory
   The directory where attachments are stored. If specified, it will be used to resolve relative paths for images.
 
+.PARAMETER ExcludeExternal
+  If specified, excludes images with external URLs (starting with https). Otherwise, all images are returned.
+
 .EXAMPLE
     Find-MarkdownImages -File "post.md"
 
@@ -30,7 +33,10 @@ function Find-MarkdownImages {
     [string]$File,
 
     [Parameter(Mandatory = $false)]
-    [string]$AttachmentsDirectory
+    [string]$AttachmentsDirectory,
+
+    [Parameter(Mandatory = $false)]
+    [switch]$ExcludeExternal
   )
 
   $content = Get-Content -Path $File -Raw
@@ -102,8 +108,8 @@ function Find-MarkdownImages {
       $title = ""  # Obsidian format doesn't support titles
     }
 
-    # Skip URLs (images already hosted online)
-    if ($imagePath -match '^https?://') {
+    # Conditionally skip external URLs if -ExcludeExternal is specified
+    if ($ExcludeExternal -and ($imagePath -match '^http(s)?://')) {
       continue
     }
 
@@ -114,7 +120,7 @@ function Find-MarkdownImages {
                       -AttachmentsDirectory $AttachmentsDirectory
 
     # Check if the file exists
-    if (Test-Path -Path $resolvedPath -PathType Leaf) {
+    if ($resolvedPath -match '^http(s)?://' -or (Test-Path -Path $resolvedPath -PathType Leaf)) {
       $images += New-MarkdownImage `
         -OriginalMarkdown $match.Value `
         -AltText $altText `
@@ -164,6 +170,10 @@ Function Resolve-ImageFilePath
     # If the path is absolute, use it as is
     $resolvedPath = $FilePath
   }
+  if ($FilePath -match '^http(s)?://') {
+    Write-Verbose "Found external image URL: $FilePath"
+    return $FilePath
+  }
   if (Test-Path $resolvedPath) {
     Write-Verbose "Found image at base directory: $resolvedPath"
     return $resolvedPath

src/public/Publish-MarkdownDriveImages.ps1

@@ -48,7 +48,7 @@ Function Publish-MarkdownDriveImages
 
   # Process images: detect, upload to Google Drive, and update markdown
   $imageMappings = @()
-  $images = Find-MarkdownImages -File $File -AttachmentsDirectory $AttachmentsDirectory
+  $images = Find-MarkdownImages -File $File -AttachmentsDirectory $AttachmentsDirectory -ExcludeExternal
 
   if ($images -and $images.Count -gt 0) {
     Write-Verbose "Found $($images.Count) local images to upload to Google Drive"

src/tests/ConvertTo-MarkdownFromHtml.Tests.ps1

@@ -26,7 +26,7 @@ Describe "ConvertTo-MarkdownFromHtml" {
       # assert
       Test-Path $script:outFile | Should -BeTrue
       $content = (Get-Content -Path $script:outFile -Raw).Split("`r")
-      $content[0] | Should -Be "# Hello World"
+      $content[0] | Should -BeLike "# Hello World*"
     }
 
     It "Should not persist to disk if OutFile is not specified" {
@@ -57,7 +57,7 @@ Describe "ConvertTo-MarkdownFromHtml" {
       # assert
       Test-Path $script:outFile | Should -BeTrue
       $content = (Get-Content -Path $script:outFile -Raw).Split("`r")
-      $content[0] | Should -Be "# Hello World"
+      $content[0] | Should -BeLike "# Hello World*"
     }
 
     It "Should convert HTML file to Markdown" {