Lock.Refresh method: use provided RetryStrategy#83
Closed
iSerganov wants to merge 1 commit into
Closed
Conversation
At the moment Refresh method doesn't do any retries and returns immediately if Redis client encounters an error. I find it misleading since Refresh accepts Options which contain RetryStrategy. So why not to use it?
dim
requested changes
May 18, 2026
Member
dim
left a comment
dim
left a comment
There was a problem hiding this comment.
Hey, so sorry, just noticed this PR. Missed it somehow completely - my apologies.
I genuinely appreciate the effort but I think you are doing too much for one PR. Could you please just submit the part where you apply the retry strategy on refresh only?
| } | ||
|
|
||
| func isRetryableRedisError(err error) bool { | ||
| return !redis.IsPermissionError(err) |
Contributor
Author
There was a problem hiding this comment.
Actually it's not, !redis.IsPermissionError(err) returns true if it is NOT a PermissionError, so this type of errors should never been retried.
|
|
||
| func setupMiniRedis(t *testing.T) (*miniredis.Miniredis, *redis.Client) { | ||
| t.Helper() | ||
| mr, err := miniredis.Run() |
Member
There was a problem hiding this comment.
I tried this, but tests still failed for me
Member
|
See #88 |
Contributor
Author
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment Refresh method doesn't do any retries and returns immediately if Redis client encounters an error. I find it misleading since Refresh accepts Options which contain RetryStrategy. So why not to use it?
Also added comprehensive unit tests for
Refresh@dim, could you please have a look whether this change makes sense to you?