Parameterize inputs and use temp output dir in external tool tests

- Use "SOUNDFONT" environment variable instead of a hardcoded path

- Use temporary directories when generating output files or interacting
  with tools that will generate output files.

Author: edudobay

Makefile

@@ -5,6 +5,17 @@ format:
 install:
 	python setup.py install
 
+test:
+	(cd unittest; python run_tests.py)
+
+test-fluidsynth:
+	(cd unittest; python run_fluidsynth_tests.py)
+
+test-lilypond:
+	(cd unittest; python run_lilypond_tests.py)
+
+test-all: test test-fluidsynth test-lilypond
+
 clean:
 	rm -rf build/ dist/
 

unittest/test_fluidsynth.py

@@ -1,26 +1,37 @@
 from __future__ import absolute_import
 
-# -*- coding: utf-8 -*-
-import sys
+import os
+import shutil
+import tempfile
+import time
+import unittest
+
 from six.moves import range
 
-sys.path += ["../"]
-from mingus.midi import fluidsynth
 from mingus.containers import *
-import unittest
-import time
+from mingus.midi import fluidsynth
 from mingus.midi.sequencer_observer import SequencerObserver
 
 
 class test_fluidsynth(unittest.TestCase):
     def setUp(self):
-        fluidsynth.init(
-            "/home/bspaans/workspace/fluidsynth/ChoriumRevA.SF2", file="test.wav"
-        )
+        soundfont = os.getenv("SOUNDFONT")
+        if soundfont is None:
+            raise ValueError(
+                "A soundfont (*.sf2) file path must be provided in the SOUNDFONT environment variable"
+            )
+
+        self.tempdir = tempfile.mkdtemp()
+        output_file = os.path.join(self.tempdir, "test.wav")
+
+        fluidsynth.init(soundfont, file=output_file)
         fluidsynth.set_instrument(0, 0)
         s = SequencerObserver()
         fluidsynth.midi.attach(s)
 
+    def tearDown(self):
+        shutil.rmtree(self.tempdir)
+
     def test_bar_velocity(self):
         b = Bar()
         n = Note("C")

unittest/test_lilypond.py

@@ -1,11 +1,12 @@
 from __future__ import absolute_import
 
-# -*- coding: utf-8 -*-
+import os
+import shutil
 import sys
+import tempfile
+import unittest
 from six.moves import map
 
-sys.path += ["../"]
-import unittest
 import mingus.extra.lilypond as LilyPond
 import mingus.core.value as value
 from mingus.containers.note import Note
@@ -17,6 +18,11 @@
 
 class test_LilyPond(unittest.TestCase):
     def setUp(self):
+        # LilyPond output files are created in current working directory
+        self.tempdir = tempfile.mkdtemp()
+        self.oldcwd = os.getcwd()
+        os.chdir(self.tempdir)
+
         self.commonbar = Bar()
         self.ebar = Bar("E", (4, 4))
         self.fbar = Bar("F", (6, 8))
@@ -44,6 +50,10 @@ def setUp(self):
         self.composition2.add_track(self.track1)
         self.composition2.add_track(self.track2)
 
+    def tearDown(self):
+        os.chdir(self.oldcwd)
+        shutil.rmtree(self.tempdir)
+
     def test_from_Note(self):
         self.assertEqual(LilyPond.from_Note(Note("C"), standalone=False), "c'")
         self.assertEqual(LilyPond.from_Note(Note("C#"), standalone=False), "cis'")