Skip to content

Commit 86177f3

Browse files
authored
Merge pull request #42 from atheler/compound-meter-rework
Compound meter rework
2 parents b3be195 + d979295 commit 86177f3

4 files changed

Lines changed: 7 additions & 6 deletions

File tree

doc/wiki/refMingusCoreMeter.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,11 @@ A meter is represented by a tuple. 4/4 time would look like (4,4), 3/4 like
4848
Examples:
4949

5050
>>> is_compound((3,4))
51-
True
51+
False
5252
>>> is_compound((4,4))
5353
False
54+
>>> is_compound((6,8))
55+
True
5456

5557

5658
----

doc/wiki/tutorialMeter.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,11 @@ Compound meter is a meter in which each measure is divided into three or more or
188188

189189

190190
>>> meter.is_compound((3, 4))
191-
True
191+
False
192192
>>> meter.is_compound((6, 8))
193193
True
194+
>>> meter.is_compound((9, 16))
195+
True
194196
>>> meter.is_compound((4, 4))
195197
False
196198

mingus/core/meter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def is_compound(meter):
5959
>>> is_compound((4,4))
6060
False
6161
"""
62-
return is_valid(meter) and meter[0] % 3 == 0
62+
return is_valid(meter) and meter[0] % 3 == 0 and 6 <= meter[0]
6363

6464

6565
def is_simple(meter):

unittest/test_meter.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,12 @@ def setUp(self):
2323
(6, 4),
2424
]
2525
self.compound_meters = [
26-
(3, 4),
2726
(6, 4),
2827
(9, 4),
2928
(12, 4),
30-
(3, 8),
3129
(6, 8),
3230
(9, 8),
3331
(12, 8),
34-
(3, 16),
3532
(6, 16),
3633
(9, 16),
3734
(12, 16),

0 commit comments

Comments
 (0)