[codex] Fix installed desktop resource bundle loading#401
Open
heodongun wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contents/Resources/CotorDesktop_CotorDesktopApp.bundleinstead of relying directly onBundle.module.Root cause
The packaged macOS app placed SwiftPM resources under
Contents/Resources, but the generatedBundle.moduleaccessor could fatal before UI startup when the installed app was launched. The fix keeps resources in the signed app resources directory and resolves them explicitly at runtime.Validation
swift testinmacos/passed with 126 tests.bash -n shell/build-desktop-app-bundle.sh && git diff --check HEAD~2..HEADpassed../gradlew --no-daemon formatCheck test -x jacocoTestCoverageVerificationpassed earlier on the fixed worktree before publish.bash shell/test-desktop-launcher-runtime.shpassed earlier on the fixed worktree./Applications/Cotor Desktop.app;codesign --verify --deep --strictpassed for the built and installed app bundles./healthwas healthy, Company/Goals/Issues/Reports/Team/Operator Chat/TUI surfaces opened, terminal HTML loaded from the packaged bundle, operator chat responded, and quitting the app left no backend/app-server child process behind.