refactor: remove unnecessary comments from HTTP requests

Cleaned up code by removing comments that indicated linting exceptions for HTTP requests, improving readability without altering functionality.

Author: mrz1836

arcade.go

@@ -976,7 +976,7 @@ func (a *Arcade) fetchBlockSubtrees(ctx context.Context, url string) ([]chainhas
 		return nil, fmt.Errorf("failed to create request: %w", err)
 	}
 
-	resp, err := a.httpClient.Do(req) //nolint:gosec // G704: URL is from configured datahub URLs, not user-controlled input
+	resp, err := a.httpClient.Do(req)
 	if err != nil {
 		return nil, fmt.Errorf("failed to fetch: %w", err)
 	}
@@ -1058,7 +1058,7 @@ func (a *Arcade) fetchHashes(ctx context.Context, url string) ([]chainhash.Hash,
 		return nil, fmt.Errorf("failed to create request: %w", err)
 	}
 
-	resp, err := a.httpClient.Do(req) //nolint:gosec // G704: URL is from configured datahub URLs, not user-controlled input
+	resp, err := a.httpClient.Do(req)
 	if err != nil {
 		return nil, fmt.Errorf("failed to fetch: %w", err)
 	}

client/client.go

@@ -70,7 +70,7 @@ func (c *Client) SubmitTransaction(ctx context.Context, rawTx []byte, opts *mode
 	req.Header.Set("Content-Type", "application/octet-stream")
 	c.setSubmitHeaders(req, opts)
 
-	resp, err := c.httpClient.Do(req) //nolint:gosec // G704: URL is built from configured baseURL, not user-controlled input
+	resp, err := c.httpClient.Do(req)
 	if err != nil {
 		return nil, fmt.Errorf("failed to submit transaction: %w", err)
 	}
@@ -113,7 +113,7 @@ func (c *Client) SubmitTransactions(ctx context.Context, rawTxs [][]byte, opts *
 	req.Header.Set("Content-Type", "application/json")
 	c.setSubmitHeaders(req, opts)
 
-	resp, err := c.httpClient.Do(req) //nolint:gosec // G704: URL is built from configured baseURL, not user-controlled input
+	resp, err := c.httpClient.Do(req)
 	if err != nil {
 		return nil, fmt.Errorf("failed to submit transactions: %w", err)
 	}
@@ -138,7 +138,7 @@ func (c *Client) GetStatus(ctx context.Context, txid string) (*models.Transactio
 		return nil, fmt.Errorf("failed to create request: %w", err)
 	}
 
-	resp, err := c.httpClient.Do(req) //nolint:gosec // G704: URL is built from configured baseURL, not user-controlled input
+	resp, err := c.httpClient.Do(req)
 	if err != nil {
 		return nil, fmt.Errorf("failed to get status: %w", err)
 	}
@@ -176,7 +176,7 @@ func (c *Client) GetPolicy(ctx context.Context) (*models.Policy, error) {
 		return nil, fmt.Errorf("failed to create request: %w", err)
 	}
 
-	resp, err := c.httpClient.Do(req) //nolint:gosec // G704: URL is built from configured baseURL, not user-controlled input
+	resp, err := c.httpClient.Do(req)
 	if err != nil {
 		return nil, fmt.Errorf("failed to get policy: %w", err)
 	}

client/sse.go

@@ -61,7 +61,7 @@ func (m *sseManager) subscribe(ctx context.Context, callbackToken string) (<-cha
 	defer m.mu.Unlock()
 
 	// Create subscriber
-	subCtx, subCancel := context.WithCancel(ctx)
+	subCtx, subCancel := context.WithCancel(ctx) //nolint:gosec // G118: cancel stored in subscriber struct, called via unsubscribe or parent context cancellation
 	sub := &subscriber{
 		id:     m.nextSubID,
 		ch:     make(chan *models.TransactionStatus, 100),
@@ -132,7 +132,7 @@ func (m *sseManager) removeSubscriber(sub *subscriber) {
 
 // createConnection creates a new SSE connection for the given token.
 func (m *sseManager) createConnection(token string) *sseConnection {
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(context.Background()) //nolint:gosec // G118: cancel stored in sseConnection struct, called in removeSubscriber
 	conn := &sseConnection{
 		token:       token,
 		ctx:         ctx,
@@ -199,7 +199,7 @@ func (m *sseManager) connectSSE(conn *sseConnection) error {
 		req.Header.Set("Last-Event-ID", conn.lastEventID)
 	}
 
-	resp, err := m.client.httpClient.Do(req) //nolint:gosec // G704: URL is built from configured baseURL, not user-controlled input
+	resp, err := m.client.httpClient.Do(req)
 	if err != nil {
 		return fmt.Errorf("failed to connect: %w", err)
 	}

cmd/arcade/main.go

@@ -157,7 +157,7 @@ func waitForShutdown(ctx context.Context, cfg *config.Config, log *slog.Logger,
 	return nil
 }
 
-func setupServer(arcadeRoutes *fiberRoutes.Routes, chaintracksRts *chaintracksRoutes.Routes, dashboard *Dashboard, authToken string, chaintracksStoragePath string) *fiber.App {
+func setupServer(arcadeRoutes *fiberRoutes.Routes, chaintracksRts *chaintracksRoutes.Routes, dashboard *Dashboard, authToken, chaintracksStoragePath string) *fiber.App {
 	app := fiber.New(fiber.Config{
 		DisableStartupMessage: true,
 	})

cmd/arcade/openapi.go

@@ -32,7 +32,7 @@ const schemaRefPrefix = "#/components/schemas/"
 
 // mergeOpenAPISpecs merges the arcade and chaintracks OpenAPI specifications.
 // It prefixes all chaintracks paths with the given pathPrefix.
-func mergeOpenAPISpecs(arcadeJSON string, pathPrefix string) (string, error) {
+func mergeOpenAPISpecs(arcadeJSON, pathPrefix string) (string, error) {
 	arcadeSpec, chaintracksSpec, err := parseSpecs(arcadeJSON)
 	if err != nil {
 		return "", err
@@ -76,7 +76,7 @@ func getOrCreateMap(parent map[string]interface{}, key string) map[string]interf
 	return m
 }
 
-func mergeChainstacksPaths(arcadePaths map[string]interface{}, chaintracksSpec map[string]interface{}, pathPrefix string) {
+func mergeChainstacksPaths(arcadePaths, chaintracksSpec map[string]interface{}, pathPrefix string) {
 	chaintracksPaths, ok := chaintracksSpec["paths"].(map[string]interface{})
 	if !ok {
 		return

config/config.go

@@ -116,7 +116,7 @@ type EventsConfig struct {
 type TeranodeConfig struct {
 	BroadcastURLs []string      `mapstructure:"broadcast_urls"` // URLs for submitting transactions
 	DataHubURLs   []string      `mapstructure:"datahub_urls"`   // URLs for fetching block/subtree data (fallback)
-	AuthToken     string        `mapstructure:"auth_token"`     //nolint:gosec // G117: this is a config field name, not a hardcoded secret
+	AuthToken     string        `mapstructure:"auth_token"`
 	Timeout       time.Duration `mapstructure:"timeout"`
 }
 

examples/sse_client.go

@@ -28,14 +28,14 @@ func main() {
 	req.Header.Set("Accept", "text/event-stream")
 
 	client := &http.Client{}
-	resp, err := client.Do(req) //nolint:gosec // G704: URL is constructed from a localhost constant, not user input
+	resp, err := client.Do(req)
 	if err != nil {
 		log.Fatal(err)
 	}
 	defer func() { _ = resp.Body.Close() }()
 
 	if resp.StatusCode != http.StatusOK {
-		log.Fatalf("Failed to connect: %s", resp.Status) //nolint:gosec // G706: resp.Status is from the HTTP response, not external user input
+		log.Fatalf("Failed to connect: %s", resp.Status)
 	}
 
 	log.Println("Connected to SSE stream...")
@@ -49,7 +49,7 @@ func main() {
 		if line == "" {
 			// Empty line signals end of event
 			if eventData != "" {
-				log.Printf("[ID: %s] [Type: %s] %s\n", eventID, eventType, eventData) //nolint:gosec // G706: SSE event data is parsed from trusted server response in this example
+				log.Printf("[ID: %s] [Type: %s] %s\n", eventID, eventType, eventData)
 				eventID, eventType, eventData = "", "", ""
 			}
 			continue

handlers/webhook.go

@@ -183,7 +183,7 @@ func (h *WebhookHandler) deliverWebhook(ctx context.Context, sub models.Submissi
 		req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", sub.CallbackToken))
 	}
 
-	resp, err := h.httpClient.Do(req) //nolint:gosec // G704: URL is from a user-registered callback, validated at registration time
+	resp, err := h.httpClient.Do(req)
 	if err != nil {
 		h.logger.Error("Failed to deliver webhook",
 			slog.String("submission_id", sub.SubmissionID),

service/embedded/embedded.go

@@ -409,7 +409,7 @@ func (e *Embedded) GetStatus(ctx context.Context, txid string) (*models.Transact
 
 // Subscribe returns a channel for transaction status updates.
 func (e *Embedded) Subscribe(ctx context.Context, callbackToken string) (<-chan *models.TransactionStatus, error) {
-	subCtx, cancel := context.WithCancel(ctx)
+	subCtx, cancel := context.WithCancel(ctx) //nolint:gosec // G118: cancel stored in subChans map, called via Unsubscribe
 	ch := e.arcade.SubscribeStatus(subCtx, callbackToken)
 
 	e.subMu.Lock()

teranode/client.go

@@ -50,7 +50,7 @@ func (c *Client) SubmitTransaction(ctx context.Context, endpoint string, rawTx [
 		req.Header.Set("Authorization", "Bearer "+c.authToken)
 	}
 
-	resp, err := c.httpClient.Do(req) //nolint:gosec // G704: URL is from configured teranode broadcast URLs, not user-controlled input
+	resp, err := c.httpClient.Do(req)
 	if err != nil {
 		return 0, fmt.Errorf("failed to submit transaction: %w", err)
 	}