fix(deploy): align manifest image references with the published GHCR namespace (#56)#130
Merged
Merged
Conversation
…namespace (#56) Manifests under deploy/ were pulling ghcr.io/galt-tr/arcade-refactor:latest, but .github/workflows/build.yml publishes to ghcr.io/bsv-blockchain/arcade. Point every Deployment at the canonical image so kubectl apply pulls the artifact CI actually produces. Tag remains :latest to match existing convention (build.yml emits :latest on main pushes). Closes #56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #56 (C-004).
The manifests under
deploy/referencedghcr.io/galt-tr/arcade-refactor:latest, an artifact CI no longer publishes..github/workflows/build.yml(lines 70-72) pushes toghcr.io/bsv-blockchain/arcade, tagged with both${{ github.sha }}and a deployment tag (latestonmain,vX.Y.Zon tag pushes). This PR repoints every Deployment at the canonical image so a freshkubectl apply -f deploy/pulls what CI actually built.The
:latesttag is preserved to match the existing convention in the manifests and whatbuild.ymlemits onmainpushes. Pinning to immutable SHAs is a separate hardening conversation and is out of scope for this C-ticket.Image references (before -> after)
deploy/all.yamlghcr.io/galt-tr/arcade-refactor:latestghcr.io/bsv-blockchain/arcade:latestdeploy/api-server.yamlghcr.io/galt-tr/arcade-refactor:latestghcr.io/bsv-blockchain/arcade:latestdeploy/bump-builder.yamlghcr.io/galt-tr/arcade-refactor:latestghcr.io/bsv-blockchain/arcade:latestdeploy/p2p-client.yamlghcr.io/galt-tr/arcade-refactor:latestghcr.io/bsv-blockchain/arcade:latestdeploy/propagation.yamlghcr.io/galt-tr/arcade-refactor:latestghcr.io/bsv-blockchain/arcade:latestdeploy/tx-validator.yamlghcr.io/galt-tr/arcade-refactor:latestghcr.io/bsv-blockchain/arcade:latestdeploy/aerospike.yaml(aerospike/aerospike-server:7.0) anddeploy/kafka.yaml(bitnami/kafka:3.7) are upstream third-party images and were not touched.Out of scope (tracked separately)
ARCADE_AEROSPIKE_HOSTSandARCADE_AEROSPIKE_NAMESPACE, butconfig/config.goregisters Viper defaults understore.aerospike.hosts/store.aerospike.namespace(see lines 469-470). Withviper.SetEnvPrefix("ARCADE")+AutomaticEnv(), those env vars resolve toaerospike.hosts/aerospike.namespace, notstore.aerospike.*, so they are silently ignored.ARCADE_KAFKA_BROKERS->kafka.brokersdoes map correctly. Flagging here for [F-034] Kubernetes manifests use Aerospike environment variables that Viper never reads #92 to address.Test plan
yamllint deploy/*.yaml- only pre-existingdocument-startwarnings and a pre-existingline-lengtherror indeploy/kafka.yaml:2(a comment); no new findings introduced by this change.image:line underdeploy/now points atghcr.io/bsv-blockchain/arcade:latestor an upstream third-party image (aerospike, kafka).:latestis the desired tag for the bootstrap manifests (vs. pinning to a SHA / version tag).