Skip to content

fix(deploy): align manifest image references with the published GHCR namespace (#56)#130

Merged
galt-tr merged 1 commit into
mainfrom
fix/issue-56-deploy-config-alignment
May 3, 2026
Merged

fix(deploy): align manifest image references with the published GHCR namespace (#56)#130
galt-tr merged 1 commit into
mainfrom
fix/issue-56-deploy-config-alignment

Conversation

@galt-tr
Copy link
Copy Markdown
Contributor

@galt-tr galt-tr commented May 3, 2026

Summary

Closes #56 (C-004).

The manifests under deploy/ referenced ghcr.io/galt-tr/arcade-refactor:latest, an artifact CI no longer publishes. .github/workflows/build.yml (lines 70-72) pushes to ghcr.io/bsv-blockchain/arcade, tagged with both ${{ github.sha }} and a deployment tag (latest on main, vX.Y.Z on tag pushes). This PR repoints every Deployment at the canonical image so a fresh kubectl apply -f deploy/ pulls what CI actually built.

The :latest tag is preserved to match the existing convention in the manifests and what build.yml emits on main pushes. Pinning to immutable SHAs is a separate hardening conversation and is out of scope for this C-ticket.

Image references (before -> after)

File Before After
deploy/all.yaml ghcr.io/galt-tr/arcade-refactor:latest ghcr.io/bsv-blockchain/arcade:latest
deploy/api-server.yaml ghcr.io/galt-tr/arcade-refactor:latest ghcr.io/bsv-blockchain/arcade:latest
deploy/bump-builder.yaml ghcr.io/galt-tr/arcade-refactor:latest ghcr.io/bsv-blockchain/arcade:latest
deploy/p2p-client.yaml ghcr.io/galt-tr/arcade-refactor:latest ghcr.io/bsv-blockchain/arcade:latest
deploy/propagation.yaml ghcr.io/galt-tr/arcade-refactor:latest ghcr.io/bsv-blockchain/arcade:latest
deploy/tx-validator.yaml ghcr.io/galt-tr/arcade-refactor:latest ghcr.io/bsv-blockchain/arcade:latest

deploy/aerospike.yaml (aerospike/aerospike-server:7.0) and deploy/kafka.yaml (bitnami/kafka:3.7) are upstream third-party images and were not touched.

Out of scope (tracked separately)

Test plan

  • yamllint deploy/*.yaml - only pre-existing document-start warnings and a pre-existing line-length error in deploy/kafka.yaml:2 (a comment); no new findings introduced by this change.
  • Grep verification: every image: line under deploy/ now points at ghcr.io/bsv-blockchain/arcade:latest or an upstream third-party image (aerospike, kafka).
  • Reviewer: confirm :latest is the desired tag for the bootstrap manifests (vs. pinning to a SHA / version tag).

…namespace (#56)

Manifests under deploy/ were pulling ghcr.io/galt-tr/arcade-refactor:latest,
but .github/workflows/build.yml publishes to ghcr.io/bsv-blockchain/arcade.
Point every Deployment at the canonical image so kubectl apply pulls the
artifact CI actually produces. Tag remains :latest to match existing
convention (build.yml emits :latest on main pushes).

Closes #56
@galt-tr galt-tr requested a review from mrz1836 as a code owner May 3, 2026 14:06
@github-actions github-actions Bot added size/S Small change (11–50 lines) bug-P3 Lowest rated bug, affects nearly none or low-impact labels May 3, 2026
@galt-tr galt-tr merged commit c292631 into main May 3, 2026
45 checks passed
@galt-tr galt-tr deleted the fix/issue-56-deploy-config-alignment branch May 3, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-P3 Lowest rated bug, affects nearly none or low-impact size/S Small change (11–50 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C-004] deployment artifacts are not generated from the runtime config contract

2 participants