Integrate reprocess behavior and break out services#140
Merged
Conversation
…ed in path expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ed in path expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
golangci-lint 2.12.2 in CI no longer flags context.WithCancel patterns where the cancel is stored for later invocation (gosec G115 / G505 relaxation), so the suppression at services/sse/manager.go:232 became unused under nolintlint. The local 2.11.4 still required it, masking the CI failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request completes the microservice decomposition of the Arcade application by extracting several previously in-process services (SSE, chaintracks, and the block-processing watchdog) into standalone deployments, each with its own configuration, ports, and Kubernetes manifests. This separation improves scalability, reliability, and maintainability by allowing each service to be managed and scaled independently. The configuration system is updated with new config blocks, sensible defaults, and validation logic for the new services.
The most important changes are:
Microservice Extraction and Deployment:
chaintracks(deploy/chaintracks.yaml),sse(deploy/sse.yaml), andwatchdog(deploy/watchdog.yaml), each with its own port and resource configuration. These services are no longer run as part of the API server or bump-builder pods. [1] [2] [3] [4] [5]deploy/all.yaml) to expose the new ports for SSE and chaintracks, ensuring proper routing and access in development and testing environments. [1] [2]Configuration System Updates:
config/config.goforWatchdogConfig,SSEConfig, and extendedChaintracksServerConfigwith host/port fields and improved documentation. These provide fine-grained control over the new microservices. [1] [2] [3]Service Wiring and Validation:
app/app.goto conditionally start the new services based on config and availability of dependencies, with appropriate logging if prerequisites are missing. [1] [2]These changes collectively modernize the Arcade deployment model, enabling independent operation and scaling of critical infrastructure components.