Fix TTL for watch calls on replay#147
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements a set of improvements and fixes for the merkle-service registration replay logic, primarily to address inefficiencies and unnecessary load during startup (issue #145). The changes add new configuration options to control replay behavior, update defaults for better performance, and ensure that successfully registered transactions are tracked to avoid redundant work. The PR also includes comprehensive tests to validate the new logic.
Key changes:
Replay Logic Improvements
PropagationConfig(merkle_replay_skip_recent_minutes,merkle_replay_rps) to control skipping recently registered transactions and rate-limiting replay requests. Updated the default replay lookback window from 7 days to 24 hours and documented the rationale for these changes. [1] [2] [3]MerkleRegisteredAttimestamp on each transaction. This prevents redundant /watch calls on restart. [1] [2] [3]Marking and Tracking Registrations
MarkMerkleRegisteredByTxIDsin the store interface and its mocks to record the time of successful merkle-service registrations. This allows the replay loop to efficiently skip already-registered transactions. [1] [2] [3]Testing Enhancements
Workflow Automation
.github/workflows/add-issues-to-project.yml) to automatically add new issues to the organization's project board for better triage and planning.Fixes #145