Skip to content

Add ARC client compatibility#36

Merged
mrz1836 merged 1 commit into
mainfrom
fix/arc-compat
Mar 26, 2026
Merged

Add ARC client compatibility#36
mrz1836 merged 1 commit into
mainfrom
fix/arc-compat

Conversation

@shruggr
Copy link
Copy Markdown
Collaborator

@shruggr shruggr commented Mar 25, 2026

Summary

  • Add X-SkipTxValidation header support — sets both SkipFeeValidation and SkipScriptValidation, matching old ARC behavior
  • Add title field to TransactionStatus response to match ARC response shape
  • Remove omitempty from status and competingTxs fields so they are always present in responses
  • Add log_level to config.example.yaml

Test plan

  • Submit transaction with X-SkipTxValidation: true header, verify no validation errors
  • Verify response JSON includes status, title, and competingTxs fields even when empty
  • Verify existing X-SkipFeeValidation and X-SkipScriptValidation headers still work independently

@shruggr
Add ARC client compatibility: X-SkipTxValidation header, title field,…
e6766a7 
… response shape fixes

- Add X-SkipTxValidation header support (sets both SkipFeeValidation and SkipScriptValidation)
- Add title field to TransactionStatus response
- Remove omitempty from status and competingTxs fields to match ARC response shape
- Add log_level to config.example.yaml
@shruggr shruggr requested a review from mrz1836 as a code owner March 25, 2026 02:36
@github-actions github-actions Bot added the size/S Small change (11–50 lines) label Mar 25, 2026
@github-actions github-actions Bot added bug-P3 Lowest rated bug, affects nearly none or low-impact feature Any new significant addition labels Mar 25, 2026
mrz1836
mrz1836 approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrz1836 mrz1836 merged commit 8e8bd84 into main Mar 26, 2026
47 checks passed
@github-actions github-actions Bot deleted the fix/arc-compat branch March 26, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrz1836 mrz1836 mrz1836 approved these changes

Assignees

@mrz1836 mrz1836

Labels

bug-P3 Lowest rated bug, affects nearly none or low-impact feature Any new significant addition size/S Small change (11–50 lines)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shruggr @mrz1836