Skip to content

Refactor to support merkle-service integration#48

Merged
mrz1836 merged 4 commits into
bsv-blockchain:mainfrom
galt-tr:refactor
Apr 28, 2026
Merged

Refactor to support merkle-service integration#48
mrz1836 merged 4 commits into
bsv-blockchain:mainfrom
galt-tr:refactor

Conversation

@galt-tr
Copy link
Copy Markdown
Contributor

@galt-tr galt-tr commented Apr 28, 2026

This pull request introduces several significant updates to the project, focusing on adding new functionality for working with BUMP data, updating build and deployment processes, and introducing configuration files for development environments. The most notable changes are the addition of the bump package for handling block data and Merkle path computations, simplification of the Dockerfile, and removal of the DEPLOY.md deployment guide.

Major new functionality: BUMP data handling

  • Added a new bump package with helpers to fetch and process block data from DataHub endpoints, including parsing binary block formats and computing Merkle paths. This includes robust error handling, per-attempt debug logging, and detailed unit tests for failure scenarios. (bump/datahub.go, bump/datahub_test.go, bump/helpers.go) [1] [2] [3]

Build and deployment process changes

  • Simplified the Dockerfile by switching to a two-stage build with a static Go binary, using Alpine 3.20, and removing explicit user setup, health checks, and configuration copy steps. The resulting image is smaller and easier to maintain.
  • Removed the comprehensive deployment guide (DEPLOY.md), which previously included instructions for Docker Compose and Kubernetes deployments, environment variables, and troubleshooting.

Development and configuration

  • Added a Makefile with common development targets for building, testing, linting, running, and managing containers via podman-compose.
  • Introduced a sample aerospike.conf configuration file for local Aerospike development, specifying service, logging, network, and namespace settings.

@galt-tr galt-tr requested a review from mrz1836 as a code owner April 28, 2026 00:41
@github-actions github-actions Bot added fork-pr PR originated from a forked repository requires-manual-review PR or issue requires manual review by a maintainer or security team labels Apr 28, 2026
@github-actions
Copy link
Copy Markdown

👋 Thanks, @galt-tr!

This pull request comes from a fork. For security, our CI runs in a restricted mode.
A maintainer will triage this shortly and run any additional checks as needed.

  • 🏷️ Labeled: fork-pr, requires-manual-review
  • 👀 We'll review and follow up here if anything else is needed.

Thanks for contributing to bsv-blockchain/arcade! 🚀

@galt-tr galt-tr requested review from shruggr and removed request for mrz1836 April 28, 2026 00:42
@mrz1836 mrz1836 self-requested a review April 28, 2026 13:42
Copy link
Copy Markdown
Collaborator

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrz1836 mrz1836 merged commit d0a3a39 into bsv-blockchain:main Apr 28, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork-pr PR originated from a forked repository requires-manual-review PR or issue requires manual review by a maintainer or security team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants