[Fix] Consolidate error format strings#29
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates duplicate error format strings used throughout safe conversion functions to improve code maintainability and address static analysis warnings about string literal duplication.
- Introduced three shared constants for error message formatting patterns
- Updated all conversion functions to use the new constants instead of hardcoded strings
- Maintained identical error message formatting while eliminating duplication
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What Changed
%w (int32): %d,%w (uint32): %d, and%w to uint32: %derror format strings.Why It Was Necessary
Testing Performed
go test ./...golangci-lint run(fails locally: unknown lintersarangolint,embeddedstructfieldcheck,wsl_v5)Impact / Risk
https://chatgpt.com/codex/tasks/task_e_68e81bb387808321bf3ee689aa363c89