perf: streaming subtree serialization with go-bt v2.6.0#100
Merged
Conversation
Replace SerializeBytes() + Write() with SerializeTo(w) in WriteTransactionsToWriter, writing transaction data directly to the io.Writer without allocating intermediate byte slices. This eliminates per-tx Output.Bytes() and Input.ExtendedBytes() allocations during subtree serialization. For a 3.64 GB block (28,672 txs), this reduced HandleBlockDirect allocations by ~10.6 GB. Depends on go-bt SerializeTo method (bsv-blockchain/go-bt#117).
Update go-bt dependency to v2.6.0 which adds zero-allocation WriteTo/ SerializeTo methods. The subtree serialization now uses SerializeTo to stream transaction data directly to the writer instead of allocating intermediate byte slices.
github-actions
Bot
added
size/S
|
oskarszoon
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SerializeTo(from go-bt v2.6.0) to stream transaction data directly to the writer during subtree serialization, eliminating intermediate[]byteallocationsPerformance Impact
When serializing subtrees for a 3.64 GB testnet block (28,672 transactions), this change eliminates the per-transaction
Bytes()allocation inSerializeSubtree. Combined with go-bt's newWriteTomethods, the full serialization path now writes directly to the output writer without intermediate buffers.Measured on HandleBlockDirect with block 1681787:
Bytes()-based approachTest plan