Skip to content

Refactor/proto wallet deprecation #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ALiberalVoluntarist wants to merge 5 commits into
base: master
Choose a base branch
from

refactor: remove WalletInterface inheritance from ProtoWallet and dep…

4a6ef22
Select commit
Loading
Failed to load commit list.
Open

Refactor/proto wallet deprecation #164

refactor: remove WalletInterface inheritance from ProtoWallet and dep…
4a6ef22
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 5, 2026 in 44s

Quality Gate passed

Issues
36 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 1079 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "args". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3D5&open=AZ6XEMNDwpbUjl5y-3D5&pullRequest=164

Check warning on line 1071 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "originator". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3D2&open=AZ6XEMNDwpbUjl5y-3D2&pullRequest=164

Check failure on line 228 in bsv/overlay_tools/lookup_resolver.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMSBwpbUjl5y-3EK&open=AZ6XEMSBwpbUjl5y-3EK&pullRequest=164

Check warning on line 591 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unneeded "pass". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3Dw&open=AZ6XEMNDwpbUjl5y-3Dw&pullRequest=164

Check warning on line 1050 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "originator". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3Dy&open=AZ6XEMNDwpbUjl5y-3Dy&pullRequest=164

Check warning on line 297 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "originator". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3Dq&open=AZ6XEMNDwpbUjl5y-3Dq&pullRequest=164

Check warning on line 1639 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "originator". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3EH&open=AZ6XEMNDwpbUjl5y-3EH&pullRequest=164

Check warning on line 1631 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "originator". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3EF&open=AZ6XEMNDwpbUjl5y-3EF&pullRequest=164

Check warning on line 1071 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "args". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3D1&open=AZ6XEMNDwpbUjl5y-3D1&pullRequest=164

Check warning on line 125 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "originator". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3Dn&open=AZ6XEMNDwpbUjl5y-3Dn&pullRequest=164

Check warning on line 1083 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "args". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3D7&open=AZ6XEMNDwpbUjl5y-3D7&pullRequest=164

Check warning on line 1327 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "originator". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3EA&open=AZ6XEMNDwpbUjl5y-3EA&pullRequest=164

Check warning on line 1639 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "args". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3EG&open=AZ6XEMNDwpbUjl5y-3EG&pullRequest=164

Check warning on line 1083 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "originator". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3D8&open=AZ6XEMNDwpbUjl5y-3D8&pullRequest=164

Check warning on line 1087 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "originator". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3D9&open=AZ6XEMNDwpbUjl5y-3D9&pullRequest=164

Check warning on line 1323 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "originator". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3D-&open=AZ6XEMNDwpbUjl5y-3D-&pullRequest=164

Check warning on line 231 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "originator". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3Dp&open=AZ6XEMNDwpbUjl5y-3Dp&pullRequest=164

Check warning on line 1348 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "originator". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3ED&open=AZ6XEMNDwpbUjl5y-3ED&pullRequest=164

Check warning on line 589 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "a". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3Dv&open=AZ6XEMNDwpbUjl5y-3Dv&pullRequest=164

Check warning on line 1067 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "originator". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3D0&open=AZ6XEMNDwpbUjl5y-3D0&pullRequest=164

Check warning on line 1966 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "args". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3EI&open=AZ6XEMNDwpbUjl5y-3EI&pullRequest=164

Check warning on line 1344 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "args". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3EB&open=AZ6XEMNDwpbUjl5y-3EB&pullRequest=164

Check warning on line 1344 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "originator". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3EC&open=AZ6XEMNDwpbUjl5y-3EC&pullRequest=164

Check warning on line 451 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "originator". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3Ds&open=AZ6XEMNDwpbUjl5y-3Ds&pullRequest=164

Check warning on line 1323 in bsv/wallet/wallet_impl.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "args". 

See more on https://sonarcloud.io/project/issues?id=bsv-blockchain_py-sdk&issues=AZ6XEMNDwpbUjl5y-3D_&open=AZ6XEMNDwpbUjl5y-3D_&pullRequest=164
View more details on SonarQubeCloud