Skip to content

Add custom volumes and mounts to deployment overrides#27

Merged
galt-tr merged 3 commits into
bsv-blockchain:masterfrom
galt-tr:customVolumes
Dec 2, 2025
Merged

Add custom volumes and mounts to deployment overrides#27
galt-tr merged 3 commits into
bsv-blockchain:masterfrom
galt-tr:customVolumes

Conversation

@galt-tr
Copy link
Copy Markdown
Contributor

@galt-tr galt-tr commented Dec 2, 2025

This pull request adds support for specifying custom Kubernetes volumes and volume mounts via DeploymentOverrides, allowing more flexible configuration of deployments. It updates the API, ensures deep copy functionality for the new fields, applies the overrides in deployment utilities, and introduces comprehensive tests to verify the new behavior.

API and Deep Copy Enhancements

  • Added Volumes and VolumeMounts fields to the DeploymentOverrides struct in interface.go to support custom volume and mount configurations.
  • Updated the autogenerated DeepCopyInto method for DeploymentOverrides to handle deep copying of the new Volumes and VolumeMounts fields, ensuring correct behavior during object duplication.

Deployment Logic Updates

  • Modified SetDeploymentOverrides in deployment.go to append custom volumes and volume mounts from DeploymentOverrides to the deployment spec, integrating these overrides into the deployment creation/update process.

Testing Improvements

  • Added a new test in cluster_controller_test.go to verify that custom volumes and mounts specified in the service are correctly propagated to the deployment and the relevant resources.
  • Updated the test environment in suite_test.go to configure etcd for handling larger requests and transactions, ensuring compatibility with more complex test scenarios.

@galt-tr galt-tr requested a review from mrz1836 as a code owner December 2, 2025 13:35
@github-actions github-actions Bot added fork-pr PR originated from a forked repository requires-manual-review PR or issue requires manual review by a maintainer or security team labels Dec 2, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

👋 Thanks, @galt-tr!

This pull request comes from a fork. For security, our CI runs in a restricted mode.
A maintainer will triage this shortly and run any additional checks as needed.

  • 🏷️ Labeled: fork-pr, requires-manual-review
  • 👀 We'll review and follow up here if anything else is needed.

Thanks for contributing to bsv-blockchain/teranode-operator! 🚀

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 2, 2025

@galt-tr galt-tr merged commit 6dae435 into bsv-blockchain:master Dec 2, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork-pr PR originated from a forked repository requires-manual-review PR or issue requires manual review by a maintainer or security team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants