Add custom volumes and mounts to deployment overrides#27
Merged
Conversation
👋 Thanks, @galt-tr!This pull request comes from a fork. For security, our CI runs in a restricted mode.
Thanks for contributing to bsv-blockchain/teranode-operator! 🚀 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request adds support for specifying custom Kubernetes volumes and volume mounts via
DeploymentOverrides, allowing more flexible configuration of deployments. It updates the API, ensures deep copy functionality for the new fields, applies the overrides in deployment utilities, and introduces comprehensive tests to verify the new behavior.API and Deep Copy Enhancements
VolumesandVolumeMountsfields to theDeploymentOverridesstruct ininterface.goto support custom volume and mount configurations.DeepCopyIntomethod forDeploymentOverridesto handle deep copying of the newVolumesandVolumeMountsfields, ensuring correct behavior during object duplication.Deployment Logic Updates
SetDeploymentOverridesindeployment.goto append custom volumes and volume mounts fromDeploymentOverridesto the deployment spec, integrating these overrides into the deployment creation/update process.Testing Improvements
cluster_controller_test.goto verify that custom volumes and mounts specified in the service are correctly propagated to the deployment and the relevant resources.suite_test.goto configure etcd for handling larger requests and transactions, ensuring compatibility with more complex test scenarios.