Change override order for CB#29
Merged
Merged
Conversation
github-actions
Bot
added
fork-pr
👋 Thanks, @galt-tr!This pull request comes from a fork. For security, our CI runs in a restricted mode.
Thanks for contributing to bsv-blockchain/teranode-operator! 🚀 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the order in which override functions are called in the
updateDeploymentmethod ofinternal/controller/coinbase_deployment.go. The change ensures that cluster-level overrides are applied before deployment-specific overrides, which can affect how configuration values are set.Deployment override ordering:
updateDeployment, moved the call toutils.SetDeploymentOverridesto occur afterutils.SetClusterOverrides, ensuring deployment-specific overrides take precedence over cluster-level settings.