Skip to content

Remove FSM integration to blockchain controller#40

Merged
galt-tr merged 2 commits into
bsv-blockchain:masterfrom
galt-tr:removeFsm
Dec 9, 2025
Merged

Remove FSM integration to blockchain controller#40
galt-tr merged 2 commits into
bsv-blockchain:masterfrom
galt-tr:removeFsm

Conversation

@galt-tr
Copy link
Copy Markdown
Contributor

@galt-tr galt-tr commented Dec 9, 2025

This pull request removes all Finite State Machine (FSM) monitoring and reconciliation features from the operator. This includes the removal of the FSM configuration from the BlockchainSpec, all related controller logic, and the supporting code and dependencies. The changes simplify the codebase and reduce external dependencies.

Removal of FSM features:

  • Removed the FiniteStateMachineSettings struct and the finiteStateMachine field from the BlockchainSpec in blockchain_types.go, eliminating FSM configuration from the CRD.
  • Deleted the entire blockchain_fsm.go file, which contained all FSM-related logic, including state reconciliation and error handling.
  • Removed FSM monitoring and reconciliation logic from the BlockchainReconciler in blockchain_controller.go, including the GetFSMState, ReconcileState, and error handling code.

Dependency cleanup:

  • Removed the teranode dependency and all related indirect dependencies from go.mod, including those for FSM operation and gRPC communication. [1] [2] [3] [4]

Controller code simplification:

  • Removed unused imports and the BlockchainClient field from the BlockchainReconciler struct in blockchain_controller.go. [1] [2]

@galt-tr galt-tr requested a review from mrz1836 as a code owner December 9, 2025 02:45
@github-actions github-actions Bot added fork-pr PR originated from a forked repository requires-manual-review PR or issue requires manual review by a maintainer or security team labels Dec 9, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2025

👋 Thanks, @galt-tr!

This pull request comes from a fork. For security, our CI runs in a restricted mode.
A maintainer will triage this shortly and run any additional checks as needed.

  • 🏷️ Labeled: fork-pr, requires-manual-review
  • 👀 We'll review and follow up here if anything else is needed.

Thanks for contributing to bsv-blockchain/teranode-operator! 🚀

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrz1836 mrz1836 added refactor Any significant refactoring update General updates labels Dec 9, 2025
@galt-tr galt-tr merged commit 51400ec into bsv-blockchain:master Dec 9, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork-pr PR originated from a forked repository refactor Any significant refactoring requires-manual-review PR or issue requires manual review by a maintainer or security team update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants