Fix image overrides for scale services

[galt-tr]

This pull request updates the image override logic for several cluster components to ensure that the cluster-level image always takes precedence, regardless of any existing deployment overrides. It also improves the test coverage and reliability for cluster reconciliation, including more thorough validation of image propagation and resource cleanup. Additionally, it enhances the test setup for custom volumes and adds brief delays to allow for resource cleanup and deployment creation.

Image override logic updates:

• The image override logic in cluster_asset.go, cluster_blockassembly.go, cluster_propagation.go, and cluster_subtreevalidator.go was changed so that the cluster's image always overrides the component's deployment override image, ensuring consistency across all components. [1] [2] [3] [4]

Test improvements for cluster reconciliation:

• Tests in cluster_controller_test.go now verify that enabling additional components (Propagation, SubtreeValidator, Pruner) correctly propagates the cluster image to those components, and that updating the cluster image triggers reconciliation and updates all relevant components. [1] [2]
• Added explicit 1-second sleeps after resource deletion and before deployment verification to ensure proper cleanup and resource readiness in tests. [1] [2]

Custom volume setup in tests:

• Custom volumes in tests are now defined with explicit EmptyDir sources, improving the accuracy and reliability of volume-related test scenarios.

Minor test and naming updates:

• Changed the resource name in blockvalidator_controller_test.go for clarity, and commented out unused reconciliation logic for future test improvements. [1] [2]
• Added missing import for time in test files to support new sleep functionality. [1] [2]

[github-actions]

👋 Thanks, @galt-tr!

This pull request comes from a fork. For security, our CI runs in a restricted mode.
A maintainer will triage this shortly and run any additional checks as needed.

• 🏷️ Labeled: fork-pr, requires-manual-review
• 👀 We'll review and follow up here if anything else is needed.

Thanks for contributing to bsv-blockchain/teranode-operator! 🚀

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[mrz1836]

LGTM