Fix override behavior for all other services#96
Merged
Conversation
github-actions
Bot
added
fork-pr
👋 Thanks, @galt-tr!This pull request comes from a fork. For security, our CI runs in a restricted mode.
Thanks for contributing to bsv-blockchain/teranode-operator! 🚀 |
|
teracoder
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the order in which deployment overrides are applied during the update of various Kubernetes deployments managed by different reconcilers. The main change is to ensure that
SetDeploymentOverridesis always called afterSetClusterOverrides, so that deployment-specific overrides take precedence over cluster-wide settings.Deployment override order correction:
utils.SetDeploymentOverrides(orutils.SetDeploymentOverridesWithContextfor propagation) to come afterutils.SetClusterOverridesin all relevant reconcilerupdateDeploymentfunctions. This ensures that deployment-specific overrides are not unintentionally overwritten by cluster-wide settings. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]