Add VerifyLowS helper function to ECDSA signature#2524
Merged
Conversation
This was referenced Apr 18, 2026
Contributor
Author
|
@gijswijs, @GustavoStingelin, @guibressan, @saubyk I opened issue #2522 to note that after upgrading secp256k1 to v4.4.0, the expected error strings in recoveryTests need to be updated to match the new error message format. The update was done because the new version exposes Signature.S(), giving direct access to the S scalar without re-parsing the DER bytes. This enables a cleaner implementation of the VerifyLowS helper added in this PR. |
The new version exposes Signature.S(), giving direct access to the S scalar without re-parsing the DER bytes. This enables a cleaner implementation of the VerifyLowS helper added in this branch.
GustavoStingelin
approved these changes
Apr 23, 2026
GustavoStingelin
left a comment
GustavoStingelin
left a comment
There was a problem hiding this comment.
LGTM as LND already uses github.com/decred/dcrd/dcrec/secp256k1/v4 v4.4.0
tACK.
Introduce a VerifyLowS helper to detect non-canonical high-S ECDSA signatures, along with unit tests.
guibressan
suggested changes
Apr 24, 2026
Update the expected error strings in recoveryTests to match the new error message format introduced by the secp256k1 v4.4.0 upgrade. Also replace reflect.DeepEqual with a string-based errorStringEqual helper to avoid type mismatches between fmt.Errorf and wrapped errors, and drop the now-unused "reflect" import.
|
ACK |
guibressan
approved these changes
Apr 24, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2462
Fix #2522
Add VerifyLowS helper function to ECDSA signature. It will be used on lightningnetwork/lnd#10372.