Skip to content

fix: update stale org/openjdk/btrace path strings to io/btrace#863

Merged
jbachorik merged 1 commit into
developfrom
develop-doc-fix
Jul 12, 2026
Merged

fix: update stale org/openjdk/btrace path strings to io/btrace#863
jbachorik merged 1 commit into
developfrom
develop-doc-fix

Conversation

@jbachorik

@jbachorik jbachorik commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

Found while auditing refactor/module-consolidation (a separate, now-superseded branch that independently reached the same module layout develop already has): a handful of path-filter and ASM-descriptor string literals still referenced the pre-repackaging org.openjdk.btrace package, missed by the org.openjdk.btrace → io.btrace repackaging.

  • BTraceExtensionPlugin: ASM annotation descriptors for ServiceDescriptor/ExtensionDescriptor used the old binary names, so bytecode scanning for these markers matched nothing (extension permission/API-partition logic silently no-op'd on these markers).
  • SingleSourceApiPartition: same descriptor mismatch for ServiceDescriptor/ExternalType.
  • PermissionScanner: JFR permission detection checked the old package prefix.
  • btrace-dist: stale doc-comment example paths (the actual classdata masking filters were already correct).
  • btrace-agent, btrace-core, btrace-dtrace, benchmarks/*: stale javadoc exclude, jacoco include filter, and shadowJar/jmhJar include filters.

Test plan

  • ./gradlew test — full suite passes
  • :btrace-gradle-plugin:test (TestKit) fails identically on unmodified develop in this environment (Gradle 9.5.1 vs. the module's JDK 11 toolchain → UnsupportedJavaRuntimeException) — confirmed pre-existing and unrelated to this change, not something this PR introduces or fixes
  • Verified no remaining org/openjdk/btrace / org.openjdk.btrace references in any .gradle/.groovy file

🤖 Generated with Claude Code


This change is Reviewable

A handful of path-filter and ASM-descriptor string literals still
referenced the pre-repackaging org.openjdk.btrace package, missed by
the org.openjdk.btrace -> io.btrace repackaging:

- BTraceExtensionPlugin: ASM annotation descriptors for
  ServiceDescriptor/ExtensionDescriptor used the old binary names, so
  bytecode scanning for these markers matched nothing.
- SingleSourceApiPartition: same descriptor mismatch for
  ServiceDescriptor/ExternalType.
- PermissionScanner: JFR permission detection checked the old package
  prefix.
- btrace-dist: doc-comment example paths, plus (functionally
  meaningful) classdata masking path filters were already correct
  except this doc block.
- btrace-agent, btrace-core, btrace-dtrace, benchmarks/*: stale
  javadoc exclude, jacoco include filter, and shadowJar/jmhJar include
  filters.

Verified with a full `./gradlew test` (all green). The
:btrace-gradle-plugin:test TestKit suite fails identically on
unmodified develop in this environment (Gradle 9.5.1 vs. the module's
JDK 11 toolchain — UnsupportedJavaRuntimeException), confirmed
pre-existing and unrelated to this change.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates remaining stale org.openjdk.btrace / org/openjdk/btrace string literals to io.btrace / io/btrace across the Gradle plugin and build tooling, aligning bytecode descriptor checks and path-based filters with the post-repackaging package layout so extension scanning and packaging filters work correctly.

Changes:

  • Fix ASM descriptor string literals used for annotation-based scanning (ServiceDescriptor, ExtensionDescriptor, ExternalType) so bytecode scanning matches again.
  • Update path-prefix checks and Gradle include/exclude filters (Shadow/JMH/Jacoco/Javadoc) to use io/btrace/....
  • Refresh a distribution build comment block example to reflect the current io/btrace/... layout.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
btrace-gradle-plugin/src/main/groovy/io/btrace/gradle/SingleSourceApiPartition.groovy Updates ASM descriptor strings for extension API partitioning to io/btrace.
btrace-gradle-plugin/src/main/groovy/io/btrace/gradle/PermissionScanner.groovy Updates JFR owner-prefix detection to io/btrace/core/jfr/.
btrace-gradle-plugin/src/main/groovy/io/btrace/gradle/BTraceExtensionPlugin.groovy Updates annotation descriptor strings used for extension/service scanning and permission extraction.
btrace-dtrace/build.gradle Updates ShadowJar include filter to the io/btrace/dtrace/** package path.
btrace-dist/build.gradle Updates fat-agent JAR structure comment examples to io/btrace/....
btrace-core/build.gradle Updates JaCoCo class include filter path to io/btrace/core/comm/**.
btrace-agent/build.gradle Updates Javadoc exclusion path for PerfReaderImpl.java to io/btrace/....
benchmarks/runtime-benchmarks/build.gradle Updates JMH jar include filters to io/btrace/... packages.
benchmarks/agent-benchmark/build.gradle Updates JMH jar include filters to io/btrace/... packages.

@jbachorik
jbachorik merged commit 3b2d644 into develop Jul 12, 2026
16 checks passed
@jbachorik
jbachorik deleted the develop-doc-fix branch July 12, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants