Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ jobs:
run: chmod +x gradlew

- name: Build plugin
run: ./gradlew buildPlugin
run: ./gradlew buildPlugin --stacktrace

- name: Run tests
run: ./gradlew test
run: ./gradlew test --stacktrace

- name: Upload test results
if: always()
Expand Down Expand Up @@ -84,10 +84,10 @@ jobs:
run: chmod +x gradlew

- name: Verify plugin descriptor
run: ./gradlew verifyPluginConfiguration
run: ./gradlew verifyPluginConfiguration --stacktrace

- name: Build plugin distribution
run: ./gradlew buildPlugin
run: ./gradlew buildPlugin --stacktrace

- name: Upload plugin artifact
uses: actions/upload-artifact@v4
Expand Down
6 changes: 4 additions & 2 deletions review-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,16 @@ kotlin {
dependencies {
intellijPlatform {
intellijIdeaCommunity("2024.1")
bundledPlugin("com.intellij.java")
pluginVerifier()
instrumentationTools()
testFramework(org.jetbrains.intellij.platform.gradle.TestFrameworkType.Platform)
}
implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3")
testImplementation(kotlin("test"))
testImplementation("junit:junit:4.13.2")
}

intellijPlatform {
buildSearchableOptions = false
pluginConfiguration {
id = "com.reviewplugin"
name = "Agent Review"
Expand All @@ -52,4 +51,7 @@ tasks {
test {
useJUnit()
}
buildSearchableOptions {
enabled = false
}
}
2 changes: 1 addition & 1 deletion review-plugin/settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ pluginManagement {
}

plugins {
id("org.gradle.toolchains.foojay-resolver-convention") version "0.9.0"
id("org.gradle.toolchains.foojay-resolver-convention") version "1.0.0"
}

rootProject.name = "review-plugin"
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ class HunkMatcherTest {
""".trimIndent()
// After first hunk: offset = (2+3)-(2+2) = 1
// Old line 5 is between hunks → 5 - 1 + 1 = 5 (0-based)
assertEquals(5, HunkMatcher.parseDiffAndRemap(diff, 6))
assertEquals(5, HunkMatcher.parseDiffAndRemap(diff, 5))
}

@Test
Expand All @@ -174,7 +174,7 @@ class HunkMatcherTest {
// Old line 5 is in the hunk (5..5)
assertNull(HunkMatcher.parseDiffAndRemap(diff, 5))
// Old line 6 is after: offset = (5+2)-(5+1) = 1, result = 6-1+1 = 6
assertEquals(6, HunkMatcher.parseDiffAndRemap(diff, 7))
assertEquals(6, HunkMatcher.parseDiffAndRemap(diff, 6))
}

// ── fuzzySearch ─────────────────────────────────────────────────
Expand Down
Loading