chore: adopt @unthrown/oxlint recommended rules

Register the unthrown oxlint plugin in .oxlintrc.json and enable the
recommended rule set as errors: no-ambiguous-error-type,
no-catch-all-pattern, no-unhandled-result, prefer-async-result (the two
opt-ins, no-throw and prefer-ensure, stay off). The package rides the
catalog and is excluded from the supply-chain maturity gate as a
first-party btravstack library.

Violations fixed:
- prefer-async-result (3): the internal never-rejecting async work
  thunks in TypedAmqpClient.create, TypedAmqpWorker.create, and
  AmqpClient.close were annotated Promise<Result<T, never>>. Dropped
  the redundant return annotations — inference yields the same type,
  and the thunks are immediately adopted by fromSafePromise, so no
  raw Promise<Result> crosses an API boundary. Removed the now-unused
  Result type import in amqp-client.ts.
- no-ambiguous-error-type, no-catch-all-pattern, no-unhandled-result:
  zero findings.

No disables were needed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: btravers

.oxlintrc.json

@@ -1,4 +1,11 @@
 {
   "$schema": "./node_modules/oxlint/configuration_schema.json",
-  "extends": ["./node_modules/@btravstack/oxlint/base.json"]
+  "extends": ["./node_modules/@btravstack/oxlint/base.json"],
+  "jsPlugins": [{ "name": "unthrown", "specifier": "@unthrown/oxlint" }],
+  "rules": {
+    "unthrown/no-ambiguous-error-type": "error",
+    "unthrown/no-catch-all-pattern": "error",
+    "unthrown/no-unhandled-result": "error",
+    "unthrown/prefer-async-result": "error"
+  }
 }

package.json

@@ -26,6 +26,7 @@
     "@btravstack/oxlint": "catalog:",
     "@changesets/cli": "catalog:",
     "@commitlint/cli": "catalog:",
+    "@unthrown/oxlint": "catalog:",
     "knip": "catalog:",
     "lefthook": "catalog:",
     "oxfmt": "catalog:",

packages/client/src/client.ts

@@ -241,7 +241,7 @@ export class TypedAmqpClient<TContract extends ContractDefinition> {
         .waitForConnectionReady()
         .flatMap(() => client.setupReplyConsumerIfNeeded());
 
-      const inner = (async (): Promise<Result<TypedAmqpClient<TContract>, never>> => {
+      const inner = (async () => {
         const setupResult = await setup;
         if (!setupResult.isOk()) {
           const closeResult = await client.close();

packages/core/src/amqp-client.ts

@@ -7,14 +7,7 @@ import type {
   CreateChannelOpts,
 } from "amqp-connection-manager";
 import type { Channel, ConsumeMessage, Options } from "amqplib";
-import {
-  fromPromise,
-  fromSafePromise,
-  fromSafeThrowable,
-  Ok,
-  type AsyncResult,
-  type Result,
-} from "unthrown";
+import { fromPromise, fromSafePromise, fromSafeThrowable, Ok, type AsyncResult } from "unthrown";
 
 import { ConnectionManagerSingleton, type ConnectionLease } from "./connection-manager.js";
 import { TechnicalError } from "./errors.js";
@@ -469,7 +462,7 @@ export class AmqpClient {
   close(): AsyncResult<void, never> {
     if (this.closing) return this.closing;
 
-    const inner = (async (): Promise<Result<void, never>> => {
+    const inner = (async () => {
       const channelResult = await fromPromise(
         this.channelWrapper.close(),
         (error: unknown, defect) => defect(new TechnicalError("Failed to close channel", error)),

packages/worker/src/worker.ts

@@ -524,7 +524,7 @@ export class TypedAmqpWorker<TContract extends ContractDefinition> {
       // If setup fails, release the AmqpClient's connection ref-count and cancel
       // any consumers that registered before the failure, so a failed create()
       // does not leak.
-      const inner = (async (): Promise<Result<TypedAmqpWorker<TContract>, never>> => {
+      const inner = (async () => {
         const setupResult = await setup;
         if (!setupResult.isOk()) {
           const closeResult = await worker.close();

pnpm-lock.yaml

@@ -28,6 +28,7 @@ catalog:
   "@orpc/zod": 1.14.8
   "@standard-schema/spec": 1.1.0
   "@types/node": 26.1.1
+  "@unthrown/oxlint": 5.0.0
   "@unthrown/vitest": 5.0.0
   "@vitest/coverage-v8": 4.1.10
   amqp-connection-manager: 5.0.0
@@ -124,6 +125,7 @@ minimumReleaseAgeExclude:
   - "@btravstack/tsconfig"
   - "@btravstack/typedoc"
   - unthrown
+  - "@unthrown/oxlint"
   - "@unthrown/vitest"
   # Temporary: fast-uri 3.1.4 (the GHSA-v2hh-gcrm-f6hx override above) is younger
   # than the 7-day cutoff. Remove once 3.1.4 is 7 days old (published 2026-07-19).