chore!: family hygiene from the amqp-contract cross-review

- rename CreateTypedClientOptions -> CreateClientOptions (the
  family-shared name for the Typed*.create() options shape, matching
  amqp-contract; its own JSDoc already claimed the shared role)
- add a package-check CI job running publint + are-the-types-wrong on
  every publishable package (mirrors amqp-contract's job)
- root package.json gains the engines field the packages already declare
- changeset $schema points at the versioned unpkg URL instead of a
  local node_modules path
- changeset entries for the declare* middleware rename, the client
  options rename, and the time-skipping testEnv fixture typing fix

Author: btravers

.changeset/config.json

@@ -1,5 +1,5 @@
 {
-  "$schema": "../node_modules/@changesets/config/schema.json",
+  "$schema": "https://unpkg.com/@changesets/config@3.1.4/schema.json",
   "changelog": "@changesets/cli/changelog",
   "commit": false,
   "fixed": [

.changeset/v8-review-remediation.md

@@ -21,6 +21,7 @@ v8 review remediation — the full-surface overhaul from the six-track 8.0 revie
 - `TypedClient` is split from the contract: `TypedClient.create({ client })` is connection-scoped, and `typedClient.for(contract)` returns the contract-bound `ContractClient` with the workflow/schedule methods. A `readonly raw` escape hatch exposes the underlying `Client`.
 - `getHandle` is synchronous, returns `Result<TypedWorkflowHandle, WorkflowNotInContractError>`, and accepts `runId`/`firstExecutionRunId` options; handles carry `runId`/`firstExecutionRunId`; typed `startUpdate` joins `executeUpdate`.
 - `WorkflowNotFoundError` is renamed `WorkflowNotInContractError`.
+- `CreateTypedClientOptions` is renamed `CreateClientOptions` — the family-shared name for the `Typed*.create()` options shape (matching amqp-contract).
 - Schedule surface parity: typed `ScheduleAlreadyExistsError`/`ScheduleNotFoundError` on the error channel (instead of defects), plus `update`, `backfill`, and `list`.
 - The six unused `ClientInfer*` type exports are deleted.
 
@@ -29,6 +30,7 @@ v8 review remediation — the full-surface overhaul from the six-track 8.0 revie
 - Invalid signal payloads are dropped and logged (`log.warn`), never thrown — `SignalInputValidationError` is deleted; a stale client can no longer terminally kill a workflow execution.
 - Contract misuse inside workflow code (unknown signal/query/update or workflow name, async schema, uncovered activity options) now fails fast as a non-retryable `ContractMisuseError` `ApplicationFailure` instead of hanging executions in Workflow Task retries.
 - Exported `qualify` is renamed `qualifyFailure` (no alias), and the deprecated `createWorkerOrThrow` is removed — use `createWorker(...).get()`.
+- `defineActivityMiddleware` is renamed `declareActivityMiddleware` — the family convention is `define*` for contract authoring and `declare*` for implementation-side APIs, and middleware was the one implementation-side holdout.
 - `activities` is optional on `createWorker`, and activity-less workflows no longer need `{}` entries in the implementations map.
 - `TypedChildWorkflowHandle` gains a typed `signals` map and `firstExecutionRunId`.
 
@@ -37,3 +39,4 @@ v8 review remediation — the full-surface overhaul from the six-track 8.0 revie
 - New contract-aware fixtures: `createContractTest(contract, { workflowsPath, activities?, workerOptions? })` yields `{ client, typedClient, worker }` against the testcontainers server, and `runActivity(definition, implementation, input, { env? })` runs one implementation inside `MockActivityEnvironment` (vitest-free).
 - Configurable environments: `createTimeSkippingTest(options?)` / `createTimeSkippingEnvironment(options?)` forward `TimeSkippingTestWorkflowEnvironmentOptions`; `createGlobalSetup({ postgresImage?, temporalImage?, temporalEnv?, quiet? })` pins container images and env.
 - The package now peer-depends on `@temporal-contract/contract`, `@temporal-contract/client`, `@temporal-contract/worker`, and `unthrown`.
+- The time-skipping `testEnv` fixture is correctly typed (the fixture record previously declared a phantom `$worker` key, leaving `testEnv` untyped in consuming suites).

.github/workflows/ci.yml

@@ -18,3 +18,14 @@ jobs:
     with:
       integration-tests: true
       node-versions: '["", "22.19.0"]'
+
+  package-check:
+    name: Package
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v7
+      - name: Setup
+        uses: ./.github/actions/setup
+      - name: Validate published surfaces (publint + are-the-types-wrong)
+        run: pnpm run check:packages

docs/how-to/upgrade-to-v8.md

@@ -264,6 +264,7 @@ carries everything the old contract-coupled client had.
 | `TypedClient.create({ contract, client })`         | `TypedClient.create({ client }).for(contract)` |
 | `TypedClient<typeof contract>` (type annotation)   | `ContractClient<typeof contract>`              |
 | `TypedClient.createOrThrow(contract, client, ...)` | removed — use `create(...).get()`              |
+| `CreateTypedClientOptions`                         | `CreateClientOptions`                          |
 
 ```typescript
 // 7.x — one client per contract, constructed per contract

package.json

@@ -32,5 +32,8 @@
     "oxlint": "catalog:",
     "turbo": "catalog:"
   },
+  "engines": {
+    "node": ">=22.19.0"
+  },
   "packageManager": "pnpm@11.7.0"
 }

packages/client/src/client.ts

@@ -474,7 +474,7 @@ async function resolveDefinitionAndValidateInput<
  * Options for {@link TypedClient.create} — the single options-object shape
  * shared by the org's `Typed*.create()` factories.
  */
-export type CreateTypedClientOptions = {
+export type CreateClientOptions = {
   /** The underlying `@temporalio/client` `Client`. */
   client: Client;
   /**
@@ -551,10 +551,7 @@ export class TypedClient {
    * const client = await TypedClient.create({ client: temporalClient }).get();
    * ```
    */
-  static create({
-    client,
-    interceptors,
-  }: CreateTypedClientOptions): AsyncResult<TypedClient, never> {
+  static create({ client, interceptors }: CreateClientOptions): AsyncResult<TypedClient, never> {
     const work = async (): Promise<Result<TypedClient, never>> => {
       // `client.schedule` is the ScheduleClient wired into Temporal's
       // top-level `Client` since 1.16. The peer dep allows all of `^1`, so a

packages/client/src/index.ts

@@ -2,7 +2,7 @@ export {
   ContractClient,
   readTypedSearchAttributes,
   TypedClient,
-  type CreateTypedClientOptions,
+  type CreateClientOptions,
   type TypedGetHandleOptions,
   type TypedSearchAttributeMap,
   type TypedSignalWithStartOptions,