Skip to content

Resolve "spot.Trade.truncate not working for xStocks"#404

Merged
btschwertfeger merged 3 commits into
masterfrom
403-spottradetruncate-not-working-for-xstocks
Sep 21, 2025
Merged

Resolve "spot.Trade.truncate not working for xStocks"#404
btschwertfeger merged 3 commits into
masterfrom
403-spottradetruncate-not-working-for-xstocks

Conversation

@btschwertfeger
Copy link
Copy Markdown
Owner

@btschwertfeger btschwertfeger commented Sep 21, 2025

Adding a new optional parameter to the truncate function to allow the use for alternative asset classes like "tokenized_asset"

Closes #403

@btschwertfeger btschwertfeger added this to the Upcoming Release milestone Sep 21, 2025
@btschwertfeger btschwertfeger self-assigned this Sep 21, 2025
@btschwertfeger btschwertfeger added Bug Something isn't working Spot Topic related to Spot trading labels Sep 21, 2025
@btschwertfeger btschwertfeger changed the title Resolve "spot.trade.truncate not working for xStocks" Resolve "spot.Trade.truncate not working for xStocks" Sep 21, 2025
@btschwertfeger btschwertfeger force-pushed the 403-spottradetruncate-not-working-for-xstocks branch from 6d393c8 to 696a79a Compare September 21, 2025 08:22
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.36%. Comparing base (4cedb97) to head (cd44998).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
+ Coverage   87.35%   87.36%   +0.01%     
==========================================
  Files          22       22              
  Lines        1961     1963       +2     
==========================================
+ Hits         1713     1715       +2     
  Misses        248      248              
Flag Coverage Δ
unittests 87.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/kraken/spot/market.py 100.00% <100.00%> (ø)
src/kraken/spot/trade.py 94.33% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@btschwertfeger btschwertfeger marked this pull request as ready for review September 21, 2025 08:57
@btschwertfeger btschwertfeger merged commit 981aa4a into master Sep 21, 2025
42 checks passed
@btschwertfeger btschwertfeger deleted the 403-spottradetruncate-not-working-for-xstocks branch September 21, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Spot Topic related to Spot trading

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spot.Trade.truncate not working for xStocks

1 participant