Commit e141d7a
fix(server): gate xorq infinite_request error_info on BUCKAROO_DEBUG
Closes #798. ``handle_infinite_request_xorq`` was returning
``traceback.format_exc()`` in the response's ``error_info`` field
unconditionally, leaking server-side source paths and stack frames to
WS clients in any production deployment.
This patch mirrors the pandas WS-handler pattern at
``websocket_handler.py:241-245``: log the full traceback server-side
(at ERROR level), but ship a generic ``"Request failed"`` to the client
unless ``BUCKAROO_DEBUG=1`` is set.
Pre-fix, the operator running a non-debug server *also* had no record
of the error (the xorq handler didn't log). This patch fixes that gap
too — same ``log.error`` shape as the pandas path.
Test from the previous commit now passes; full ``test_load_expr.py``
suite green.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 1da4ee3 commit e141d7a
1 file changed
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
18 | 26 | | |
19 | 27 | | |
20 | 28 | | |
| |||
87 | 95 | | |
88 | 96 | | |
89 | 97 | | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
90 | 103 | | |
91 | | - | |
| 104 | + | |
| 105 | + | |
0 commit comments