-
Notifications
You must be signed in to change notification settings - Fork 16
feat(server): POST /reset to clear a session without restart (#812) #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paddymul
wants to merge
2
commits into
main
Choose a base branch
from
feat/session-reset-endpoint-812
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit adds multiple assertions that
POST /resetreturns 200 and clears session state, but no server handler/route is added in the same change, so these calls hit an unmapped endpoint (404) and the new tests fail immediately. I verified the current server route table only includes/load,/load_expr,/load_compare, and/ws/...(no/reset), so this feature commit is incomplete and will keep CI red until the endpoint is implemented.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the intentional TDD split — the failing tests in commit
43ce45fewere committed first so they could be observed failing on CI before the fix landed; theResetHandlerroute + handler +SessionState.reset()are all in the next commit32697a88(this same review). The PR description's test plan notes the two CI runs (one red for tests-only, one green for fix).Project convention (global CLAUDE.md): "NEVER bundle a test with the fix that makes it pass — the test must be seen failing on CI first." So a per-commit complaint about "tests reference behaviour the commit doesn't implement" is a false positive on the test-only commit; the contract is checked against the PR head, not each commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stale: this comment was made against the test-first commit (43ce45f), not the PR head. The PR head (32697a8) does add the route —
(r"/reset", ResetHandler)in server/app.py plusclass ResetHandlerin handlers.py. The visible "CI red" on this PR is a CI-infra git push failure, not a 404 from the new tests.