Skip to content

fix(js): export parquetRead/parquetMetadata from static-embed.js #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paddymul wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(js): export parquetRead/parquetMetadata from static-embed.js #858

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d8fc64
fix(js): export parquetRead/parquetMetadata from static-embed.js (#857)
paddymul May 24, 2026
7cc369b
fix(js): add renderArtifact export and idle main() for library use
paddymul May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions packages/js/static-embed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,16 @@ import * as ReactDOM from "react-dom/client";
import { BuckarooStaticTable, resolveDFDataAsync, preResolveDFDataDict } from "buckaroo-js-core";
import "../buckaroo-js-core/dist/style.css";

async function main() {
const dataEl = document.getElementById("buckaroo-data");
if (!dataEl?.textContent) {
throw new Error("No #buckaroo-data script block found");
}
const artifact = JSON.parse(dataEl.textContent);

const rootEl = document.getElementById("root");
if (!rootEl) throw new Error("No #root element found");
// Named exports so callers can import parquetRead from static-embed.js directly
// and feed raw ArrayBuffer parquet (e.g. from fetch()) without base64 encoding.
// Re-exported via buckaroo-js-core (which re-exports from hyparquet) to keep a
// single source of truth for the parquet decoder.
export { parquetRead, parquetMetadata, resolveDFDataAsync, preResolveDFDataDict } from "buckaroo-js-core";

// Pre-resolve parquet_b64 payloads before React render
// Resolve any parquet_b64 payloads in the artifact and render it into rootEl.
// Exported so callers that fetch raw parquet (via the exported parquetRead)
// can build an artifact at runtime and trigger the same render main() does.
export async function renderArtifact(rootEl: HTMLElement, artifact: any) {
const [dfData, summaryStatsData] = await Promise.all([
resolveDFDataAsync(artifact.df_data),
resolveDFDataAsync(artifact.summary_stats_data),
Expand All @@ -26,11 +25,9 @@ async function main() {
summary_stats_data: summaryStatsData,
};

// For Buckaroo mode, pre-resolve all parquet_b64 values in df_data_dict
if (artifact.embed_type === "Buckaroo" && artifact.df_data_dict) {
resolved.df_display_args = artifact.df_display_args;
resolved.df_data_dict = await preResolveDFDataDict(artifact.df_data_dict);
// Ensure "main" key has the already-resolved data
resolved.df_data_dict["main"] = dfData;
resolved.df_meta = artifact.df_meta;
resolved.buckaroo_options = artifact.buckaroo_options;
Expand All @@ -45,6 +42,16 @@ async function main() {
);
}

async function main() {
const dataEl = document.getElementById("buckaroo-data");
// When the bundle is imported purely as a library (for parquetRead / renderArtifact),
// there is no #buckaroo-data; silently skip auto-init instead of erroring.
if (!dataEl?.textContent) return;
const rootEl = document.getElementById("root");
if (!rootEl) throw new Error("No #root element found");
await renderArtifact(rootEl, JSON.parse(dataEl.textContent));
}

main().catch((e) => {
console.error("Buckaroo static embed init failed:", e);
const rootEl = document.getElementById("root");
Expand Down
Loading