Skip to content

Unskip ReDoS test #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timostamm wants to merge 1 commit into
base: jonbodner/add_re2
Choose a base branch
from
Open

Unskip ReDoS test #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cel/src/std/logic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function durationOf(func: () => void, times = 5): number {

void suite("logic", () => {
void suite("matches(string, string) -> bool", () => {
void test.skip("doesn't evaluate simple ReDoS expressions in exponential time", () => {
void test("doesn't evaluate simple ReDoS expressions in exponential time", () => {
Copy link
Copy Markdown

@jonbodner-buf jonbodner-buf Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge this before the re2js merge?

Copy link
Copy Markdown

@jonbodner-buf jonbodner-buf Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently not, it depends on @bufbuild/re2

Copy link
Copy Markdown
Member Author

@timostamm timostamm Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is a guard against ReDoS. It fails with the current implementation on main, and I expect it to pass in your branch.

It's currently skipped on main because it fails on main. We could merge this change into main, but it means CI would be red, and we'd be stuck if some other work comes along before we can merge your branch.

const maliciousRegex = "^(a*)*$";
const overhead = durationOf(() => matches.call("!", maliciousRegex));

Expand Down
Loading