Skip to content

Commit 79fb2f8

Browse files
authored
Update protovalidate to v1.2.0 (#144)
Update prototovalidate to `v1.2.0`. This version updated the messages to remove the `value` prefix. Signed-off-by: Sri Krishna <skrishna@buf.build>
1 parent 6efb0ed commit 79fb2f8

4 files changed

Lines changed: 13 additions & 13 deletions

File tree

MODULE.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,4 @@ bazel_dep(name = "abseil-cpp", version = "20240722.0", repo_name = "com_google_a
3333

3434
bazel_dep(name = "cel-cpp", version = "0.11.0", repo_name = "com_google_cel_cpp")
3535

36-
bazel_dep(name = "protovalidate", version = "1.1.1", repo_name = "com_github_bufbuild_protovalidate")
36+
bazel_dep(name = "protovalidate", version = "1.2.0", repo_name = "com_github_bufbuild_protovalidate")

MODULE.bazel.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

buf/validate/validator_test.cc

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ TEST(ValidatorTest, ValidateBool) {
8080
ASSERT_TRUE(violations_or.ok()) << violations_or.status();
8181
ASSERT_EQ(violations_or.value().violations_size(), 1);
8282
EXPECT_EQ(violations_or.value().violations(0).proto().rule_id(), "bool.const");
83-
EXPECT_EQ(violations_or.value().violations(0).proto().message(), "value must equal false");
83+
EXPECT_EQ(violations_or.value().violations(0).proto().message(), "must equal false");
8484
}
8585

8686
TEST(ValidatorTest, ValidateStrRepeatedUniqueSuccess) {
@@ -141,7 +141,7 @@ TEST(ValidatorTest, ValidateRelativeURIFailure) {
141141
ASSERT_TRUE(violations_or.ok()) << violations_or.status();
142142
EXPECT_EQ(violations_or.value().violations_size(), 1);
143143
EXPECT_EQ(violations_or.value().violations(0).proto().rule_id(), "string.uri");
144-
EXPECT_EQ(violations_or.value().violations(0).proto().message(), "value must be a valid URI");
144+
EXPECT_EQ(violations_or.value().violations(0).proto().message(), "must be a valid URI");
145145
EXPECT_THAT(
146146
violations_or.value().violations(0).field_value(),
147147
Optional(FieldValueOf(VariantWith<std::string>("/foo/bar?baz=quux"))));
@@ -202,7 +202,7 @@ TEST(ValidatorTest, ValidateBadURIRefFailure) {
202202
EXPECT_EQ(violations_or.value().violations_size(), 1);
203203
EXPECT_EQ(violations_or.value().violations(0).proto().rule_id(), "string.uri_ref");
204204
EXPECT_EQ(
205-
violations_or.value().violations(0).proto().message(), "value must be a valid URI Reference");
205+
violations_or.value().violations(0).proto().message(), "must be a valid URI Reference");
206206
EXPECT_THAT(
207207
violations_or.value().violations(0).field_value(),
208208
Optional(FieldValueOf(VariantWith<std::string>("!@#$%^&*"))));
@@ -251,7 +251,7 @@ TEST(ValidatorTest, ValidateStringContainsFailure) {
251251
EXPECT_EQ(violations_or.value().violations(0).proto().rule_id(), "string.contains");
252252
EXPECT_EQ(
253253
violations_or.value().violations(0).proto().message(),
254-
"value does not contain substring `bar`");
254+
"does not contain substring `bar`");
255255
}
256256

257257
TEST(ValidatorTest, ValidateStringContainsSuccess) {
@@ -279,7 +279,7 @@ TEST(ValidatorTest, ValidateBytesContainsFailure) {
279279
ASSERT_TRUE(violations_or.ok()) << violations_or.status();
280280
EXPECT_EQ(violations_or.value().violations_size(), 1);
281281
EXPECT_EQ(violations_or.value().violations(0).proto().rule_id(), "bytes.contains");
282-
EXPECT_EQ(violations_or.value().violations(0).proto().message(), "value does not contain 626172");
282+
EXPECT_EQ(violations_or.value().violations(0).proto().message(), "does not contain 626172");
283283
}
284284

285285
TEST(ValidatorTest, ValidateBytesContainsSuccess) {
@@ -308,7 +308,7 @@ TEST(ValidatorTest, ValidateStartsWithFailure) {
308308
EXPECT_EQ(violations_or.value().violations_size(), 1);
309309
EXPECT_EQ(violations_or.value().violations(0).proto().rule_id(), "string.prefix");
310310
EXPECT_EQ(
311-
violations_or.value().violations(0).proto().message(), "value does not have prefix `foo`");
311+
violations_or.value().violations(0).proto().message(), "does not have prefix `foo`");
312312
}
313313

314314
TEST(ValidatorTest, ValidateStartsWithSuccess) {
@@ -337,7 +337,7 @@ TEST(ValidatorTest, ValidateEndsWithFailure) {
337337
EXPECT_EQ(violations_or.value().violations_size(), 1);
338338
EXPECT_EQ(violations_or.value().violations(0).proto().rule_id(), "string.suffix");
339339
EXPECT_EQ(
340-
violations_or.value().violations(0).proto().message(), "value does not have suffix `baz`");
340+
violations_or.value().violations(0).proto().message(), "does not have suffix `baz`");
341341
}
342342

343343
TEST(ValidatorTest, ValidateHostnameSuccess) {

deps/shared_deps.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@
3838
},
3939
"protovalidate": {
4040
"meta": {
41-
"version": "1.1.1"
41+
"version": "1.2.0"
4242
},
4343
"source": {
44-
"sha256": "297dba5cdc25fa478c597e53af6c4ccf330c826e566384774b5176c13c8d3bd8",
44+
"sha256": "9aee9beede94edc62fa472a58c964741f11e1a0ab7472f12cfb98381c2f502fd",
4545
"strip_prefix": "protovalidate-{version}",
4646
"urls": [
4747
"https://github.com/bufbuild/protovalidate/releases/download/v{version}/protovalidate-{version}.tar.gz"

0 commit comments

Comments
 (0)