Remove incomplete plan from cache when compilation fails (#137)

Co-authored-by: Sri Krishna <93153132+srikrsna-buf@users.noreply.github.com>

Author: dbrain

packages/protovalidate/src/planner.ts

@@ -96,11 +96,16 @@ export class Planner {
     const messageRules = getOption(message, ext_message);
     const e = new EvalMany<ReflectMessage>();
     this.messageCache.set(message, e);
-    e.add(this.fields(messageRules.oneof, message.fields));
-    e.add(this.messageCel(messageRules));
-    e.add(this.messageOneofs(message, messageRules.oneof));
-    e.add(this.oneofs(message.oneofs));
-    e.prune();
+    try {
+      e.add(this.fields(messageRules.oneof, message.fields));
+      e.add(this.messageCel(messageRules));
+      e.add(this.messageOneofs(message, messageRules.oneof));
+      e.add(this.oneofs(message.oneofs));
+      e.prune();
+    } catch (err) {
+      this.messageCache.delete(message);
+      throw err;
+    }
     return e;
   }
 

packages/protovalidate/src/validator.test.ts

@@ -329,6 +329,22 @@ void suite("Validator", () => {
       );
       assert.ok(result.error instanceof CompilationError);
     });
+    void test("unknown extension raises error on every call", () => {
+      const validator = createValidator();
+      const person = create(personSchema, {
+        name: "Pauly Shore",
+      });
+      const result = validator.validate(personSchema, person);
+      assert.equal(result.kind, "error", "first call should explode");
+      assert.ok(result.error instanceof CompilationError);
+      const retryResult = validator.validate(personSchema, person);
+      assert.equal(
+        retryResult.kind,
+        "error",
+        "second call should also explode",
+      );
+      assert.ok(retryResult.error instanceof CompilationError);
+    });
     void test("registered extension validates", () => {
       const validator = createValidator({
         registry: createRegistry(ext_abc),